From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toshi Kani Subject: Re: [PATCH] ACPI, cpu hotplug: move try_offline_node() after acpi_unmap_lsapic() Date: Tue, 06 Aug 2013 10:56:18 -0600 Message-ID: <1375808178.10300.181.camel@misato.fc.hp.com> References: <5200CBBF.1090904@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from g4t0016.houston.hp.com ([15.201.24.19]:17172 "EHLO g4t0016.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755686Ab3HFQ5Z (ORCPT ); Tue, 6 Aug 2013 12:57:25 -0400 In-Reply-To: <5200CBBF.1090904@jp.fujitsu.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Yasuaki Ishimatsu Cc: rafael.j.wysocki@intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, 2013-08-06 at 19:11 +0900, Yasuaki Ishimatsu wrote: > try_offline_node() checks that all cpus related with removed node have been > removed by using cpu_present_bits. If all cpus related with removed node have > been removed, try_offline_node() clears the node information. > > But try_offline_node() called from acpi_processor_remove() never clears > the node information. For disabling cpu_present_bits, acpi_unmap_lsapic() > need be called. But acpi_unmap_lsapic() is called after try_offline_node() > runs. So when try_offline_node() runs, the cpu's cpu_present_bits is always > set. > > This patch moves try_offline_node() after acpi_unmap_lsapic(). > > Signed-off-by: Yasuaki Ishimatsu The change looks good to me. Acked-by: Toshi Kani BTW, do you know why try_offline_node() has to use stop_machine()? Thanks, -Toshi