From: Tang Chen <tangchen@cn.fujitsu.com>
To: robert.moore@intel.com, lv.zheng@intel.com, rjw@sisk.pl,
lenb@kernel.org, tglx@linutronix.de, mingo@elte.hu,
hpa@zytor.com, akpm@linux-foundation.org, tj@kernel.org,
trenn@suse.de, yinghai@kernel.org, jiang.liu@huawei.com,
wency@cn.fujitsu.com, laijs@cn.fujitsu.com,
isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com,
mgorman@suse.de, minchan@kernel.org, mina86@mina86.com,
gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com,
lwoodman@redhat.com, riel@redhat.com, jweiner@redhat.com,
prarit@redhat.com, zhangyanfei@cn.fujitsu.com,
yanghy@cn.fujitsu.com
Cc: x86@kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-acpi@vger.kernel.org
Subject: [PATCH part5 1/7] x86: get pg_data_t's memory from other node
Date: Thu, 8 Aug 2013 18:16:13 +0800 [thread overview]
Message-ID: <1375956979-31877-2-git-send-email-tangchen@cn.fujitsu.com> (raw)
In-Reply-To: <1375956979-31877-1-git-send-email-tangchen@cn.fujitsu.com>
From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
If system can create movable node which all memory of the node is allocated
as ZONE_MOVABLE, setup_node_data() cannot allocate memory for the node's
pg_data_t. So, use memblock_alloc_try_nid() instead of memblock_alloc_nid()
to retry when the first allocation fails. Otherwise, the system could failed
to boot.
The node_data could be on hotpluggable node. And so could pagetable and
vmemmap. But for now, doing so will break memory hot-remove path.
A node could have several memory devices. And the device who holds node
data should be hot-removed in the last place. But in NUMA level, we don't
know which memory_block (/sys/devices/system/node/nodeX/memoryXXX) belongs
to which memory device. We only have node. So we can only do node hotplug.
But in virtualization, developers are now developing memory hotplug in qemu,
which support a single memory device hotplug. So a whole node hotplug will
not satisfy virtualization users.
So at last, we concluded that we'd better do memory hotplug and local node
things (local node node data, pagetable, vmemmap, ...) in two steps.
Please refer to https://lkml.org/lkml/2013/6/19/73
For now, we put node_data of movable node to another node, and then improve
it in the future.
In the later patches, a boot option will be introduced to enable/disable this
functionality. If users disable it, the node_data will still be put on the
local node.
Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Reviewed-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Acked-by: Toshi Kani <toshi.kani@hp.com>
---
arch/x86/mm/numa.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c
index 8bf93ba..d532b6d 100644
--- a/arch/x86/mm/numa.c
+++ b/arch/x86/mm/numa.c
@@ -209,10 +209,9 @@ static void __init setup_node_data(int nid, u64 start, u64 end)
* Allocate node data. Try node-local memory and then any node.
* Never allocate in DMA zone.
*/
- nd_pa = memblock_alloc_nid(nd_size, SMP_CACHE_BYTES, nid);
+ nd_pa = memblock_alloc_try_nid(nd_size, SMP_CACHE_BYTES, nid);
if (!nd_pa) {
- pr_err("Cannot find %zu bytes in node %d\n",
- nd_size, nid);
+ pr_err("Cannot find %zu bytes in any node\n", nd_size);
return;
}
nd = __va(nd_pa);
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-08-08 10:16 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 10:16 [PATCH part5 0/7] Arrange hotpluggable memory as ZONE_MOVABLE Tang Chen
2013-08-08 10:16 ` Tang Chen [this message]
2013-08-12 14:39 ` [PATCH part5 1/7] x86: get pg_data_t's memory from other node Tejun Heo
2013-08-12 15:12 ` Tang Chen
2013-08-08 10:16 ` [PATCH part5 2/7] x86, numa, mem_hotplug: Skip all the regions the kernel resides in Tang Chen
2013-08-08 10:16 ` [PATCH part5 3/7] memblock, numa: Introduce flag into memblock Tang Chen
2013-08-08 10:16 ` [PATCH part5 4/7] memblock, mem_hotplug: Introduce MEMBLOCK_HOTPLUG flag to mark hotpluggable regions Tang Chen
2013-08-08 10:16 ` [PATCH part5 5/7] memblock, mem_hotplug: Make memblock skip hotpluggable regions by default Tang Chen
2013-08-14 21:54 ` Naoya Horiguchi
2013-08-15 5:15 ` Tang Chen
2013-08-08 10:16 ` [PATCH part5 6/7] mem-hotplug: Introduce movablenode boot option to {en|dis}able using SRAT Tang Chen
2013-08-08 10:16 ` [PATCH part5 7/7] x86, numa, acpi, memory-hotplug: Make movablenode have higher priority Tang Chen
2013-08-09 16:32 ` [PATCH part5 0/7] Arrange hotpluggable memory as ZONE_MOVABLE Tejun Heo
2013-08-12 6:33 ` Tang Chen
2013-08-12 8:54 ` Tang Chen
2013-08-12 14:50 ` Tejun Heo
2013-08-12 15:14 ` H. Peter Anvin
2013-08-12 15:23 ` Tejun Heo
2013-08-12 16:29 ` Tang Chen
2013-08-12 16:46 ` Tejun Heo
2013-08-12 18:23 ` Tang Chen
2013-08-12 20:20 ` Tejun Heo
2013-08-12 20:49 ` Luck, Tony
2013-08-12 20:54 ` Tejun Heo
2013-08-12 20:57 ` H. Peter Anvin
2013-08-12 21:06 ` Yinghai Lu
2013-08-12 21:08 ` Tejun Heo
2013-08-12 21:12 ` H. Peter Anvin
2013-08-12 21:14 ` Tejun Heo
2013-08-12 21:11 ` H. Peter Anvin
2013-08-12 21:11 ` Luck, Tony
2013-08-12 21:25 ` Yinghai Lu
2013-08-12 21:28 ` H. Peter Anvin
2013-08-13 5:14 ` H. Peter Anvin
2013-08-13 6:14 ` Tang Chen
2013-08-13 9:56 ` Tang Chen
2013-08-13 14:38 ` Tejun Heo
2013-08-13 22:33 ` Yinghai Lu
2013-08-14 1:22 ` Tang Chen
2013-08-15 19:06 ` Toshi Kani
2013-08-15 20:28 ` Yinghai Lu
2013-08-16 2:08 ` Tang Chen
2013-08-16 4:21 ` Yinghai Lu
2013-08-19 3:07 ` Tang Chen
2013-08-19 3:28 ` Yinghai Lu
2013-08-15 8:42 ` Tang Chen
2013-08-15 12:19 ` Tejun Heo
2013-08-15 12:44 ` Tang Chen
2013-08-15 12:49 ` Tejun Heo
2013-08-15 12:52 ` Tang Chen
2013-08-15 14:37 ` Yinghai Lu
2013-08-15 14:45 ` Tejun Heo
2013-08-15 15:05 ` Yinghai Lu
2013-08-15 15:10 ` Tejun Heo
2013-08-15 19:49 ` Toshi Kani
2013-08-15 19:08 ` Luck, Tony
2013-08-15 19:34 ` Yinghai Lu
2013-08-15 14:35 ` Yinghai Lu
2013-08-16 1:16 ` Tang Chen
2013-08-12 15:41 ` Tang Chen
2013-08-12 15:46 ` Tejun Heo
2013-08-12 16:19 ` Tang Chen
2013-08-12 16:22 ` Tejun Heo
2013-08-12 17:01 ` Tang Chen
2013-08-12 17:23 ` H. Peter Anvin
2013-08-14 18:22 ` KOSAKI Motohiro
2013-08-12 18:07 ` Tejun Heo
2013-08-14 18:15 ` KOSAKI Motohiro
2013-08-14 18:23 ` Tejun Heo
2013-08-14 19:40 ` KOSAKI Motohiro
2013-08-14 19:55 ` Tejun Heo
2013-08-14 20:29 ` KOSAKI Motohiro
2013-08-14 20:30 ` H. Peter Anvin
2013-08-14 20:35 ` Tejun Heo
2013-08-14 21:17 ` KOSAKI Motohiro
2013-08-14 21:36 ` Tejun Heo
2013-08-15 1:08 ` KOSAKI Motohiro
2013-08-15 1:21 ` Tejun Heo
2013-08-15 1:33 ` Tejun Heo
2013-08-15 1:44 ` KOSAKI Motohiro
2013-08-15 2:22 ` Tejun Heo
2013-08-15 1:38 ` KOSAKI Motohiro
2013-08-15 1:51 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375956979-31877-2-git-send-email-tangchen@cn.fujitsu.com \
--to=tangchen@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=gong.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=jiang.liu@huawei.com \
--cc=jweiner@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lv.zheng@intel.com \
--cc=lwoodman@redhat.com \
--cc=mgorman@suse.de \
--cc=mina86@mina86.com \
--cc=minchan@kernel.org \
--cc=mingo@elte.hu \
--cc=prarit@redhat.com \
--cc=riel@redhat.com \
--cc=rjw@sisk.pl \
--cc=robert.moore@intel.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=trenn@suse.de \
--cc=vasilis.liaskovitis@profitbricks.com \
--cc=wency@cn.fujitsu.com \
--cc=x86@kernel.org \
--cc=yanghy@cn.fujitsu.com \
--cc=yinghai@kernel.org \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).