Re: [PATCH v2 0/3] Fix Win8 backlight issue - Yves-Alexis Perez

From: Yves-Alexis Perez <corsac@debian.org>
To: Aaron Lu <aaron.lu@intel.com>
Cc: Matthew Garrett <matthew.garrett@nebula.com>,
	Seth Forshee <seth.forshee@canonical.com>,
	intel-gfx@lists.freedesktop.org,
	Felipe Contreras <felipe.contreras@gmail.com>,
	Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	linux-acpi@vger.kernel.org, Lee Chun-Yi <joeyli.kernel@gmail.com>,
	Richard Purdie <rpurdie@rpsys.net>,
	Igor Gnatenko <i.gnatenko.brain@gmail.com>
Subject: Re: [PATCH v2 0/3] Fix Win8 backlight issue
Date: Fri, 20 Sep 2013 15:00:15 +0200	[thread overview]
Message-ID: <1379682015.9746.3.camel@oban> (raw)
In-Reply-To: <1379409796-29350-1-git-send-email-aaron.lu@intel.com>

[-- Attachment #1.1: Type: text/plain, Size: 1392 bytes --]

On mar., 2013-09-17 at 17:23 +0800, Aaron Lu wrote:
> v1 has the subject of "Rework ACPI video driver" and is posted here:
> http://lkml.org/lkml/2013/9/9/74
> Since the objective is really to fix Win8 backlight issues, I changed
> the subject in this version, sorry about that.
> 
> This patchset has three patches, the first introduced a new API named
> backlight_device_registered in backlight layer that can be used for
> backlight interface provider module to check if a specific type
> backlight
> interface has been registered, see changelog for patch 1/3 for
> details.
> Then patch 2/3 does the cleanup to sepeate the backlight control and
> event delivery functionality in the ACPI video module and patch 3/3
> solves some Win8 backlight control problems by avoiding register ACPI
> video's backlight interface if:
> 1 Kernel cmdline option acpi_backlight=video is not given;
> 2 This is a Win8 system;
> 3 Native backlight control interface exists.

I've tested this on my x230 (using pure UEFI with CSM disabled). As far
as I can tell, it works as I would expect:

- brightness keys work in initramfs, in console after boot, in lightdm
prompt and in Xfce (wether or not xfce4-power-manager is running).

I don't have brightness notifications (from xfce4-power-manager) but I
don't usually need them so I'm fine with that.

Regards,
-- 
Yves-Alexis

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx