linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tianyu.lan@intel.com
To: lenb@kernel.org, rjw@rjwysocki.net
Cc: Lan Tianyu <tianyu.lan@intel.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ACPI/Power: Check physical device's runtime pm status before requesting to resume it
Date: Fri, 11 Oct 2013 16:16:25 +0800	[thread overview]
Message-ID: <1381479385-1614-1-git-send-email-tianyu.lan@intel.com> (raw)

From: Lan Tianyu <tianyu.lan@intel.com>

Currently, when one power resource is turned on, devices owning it
will be requested to resume regardless of their runtime pm status.
ACPI power resource maybe turn on in some devices' runtime pm
resume callback(E.G, usb port) while turning on the power resource
will trigger one new resume request of the device. It causes
infinite loop between resume and suspend. This has happened on
clearing usb port's PM Qos NO_POWER_OFF flag twice. This patch is
to add check of physical device's runtime pm status and request resume
if the device is suspended.

Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
---
 drivers/acpi/power.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
index 0dbe5cd..228c138 100644
--- a/drivers/acpi/power.c
+++ b/drivers/acpi/power.c
@@ -250,8 +250,10 @@ static void acpi_power_resume_dependent(struct work_struct *work)
 
 	mutex_lock(&adev->physical_node_lock);
 
-	list_for_each_entry(pn, &adev->physical_node_list, node)
-		pm_request_resume(pn->dev);
+	list_for_each_entry(pn, &adev->physical_node_list, node) {
+		if (pm_runtime_suspended(pn->dev))
+			pm_request_resume(pn->dev);
+	}
 
 	list_for_each_entry(pn, &adev->power_dependent, node)
 		pm_request_resume(pn->dev);
-- 
1.8.4.rc0.1.g8f6a3e5.dirty


             reply	other threads:[~2013-10-11  8:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-11  8:16 tianyu.lan [this message]
2013-10-11 11:19 ` [PATCH] ACPI/Power: Check physical device's runtime pm status before requesting to resume it Rafael J. Wysocki
2013-10-15  8:58   ` Lan Tianyu
2013-10-15 21:22     ` Rafael J. Wysocki
2013-10-16  7:12       ` Lan Tianyu
2013-10-16  8:57       ` Lan Tianyu
2013-10-16  9:26       ` Lan Tianyu
2013-10-16 12:42         ` Rafael J. Wysocki
2013-10-17  1:02           ` Lan Tianyu
2013-10-17  2:40             ` Lan Tianyu
2013-10-17  8:50               ` Lan Tianyu
2013-10-17 11:38               ` Rafael J. Wysocki
2013-10-18 13:05                 ` Lan Tianyu
2013-10-18 17:54                   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381479385-1614-1-git-send-email-tianyu.lan@intel.com \
    --to=tianyu.lan@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).