From: Toshi Kani <toshi.kani@hp.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux PCI <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH 2/3] ACPI / hotplug: Fix PCI host bridge hot removal
Date: Mon, 18 Nov 2013 11:10:05 -0700 [thread overview]
Message-ID: <1384798205.1791.14.camel@misato.fc.hp.com> (raw)
In-Reply-To: <3206422.AfXMUDqMXZ@vostro.rjw.lan>
On Thu, 2013-11-14 at 00:16 +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Since the PCI host bridge scan handler does not set hotplug.enabled,
> the check of it in acpi_bus_device_eject() effectively prevents the
> root bridge hot removal from working after commit a3b1b1ef78cd
> (ACPI / hotplug: Merge device hot-removal routines). However, that
> check is not necessary, because the other acpi_bus_device_eject()
> users, acpi_hotplug_notify_cb and acpi_eject_store(), do the same
> check by themselves before executing that function.
>
> For this reason, remove the scan handler check from
> acpi_bus_device_eject() to make PCI hot bridge hot removal work
> again.
I am curious why the PCI host bridge scan handler does not set
hotplug.enabled. Is this how it disables hotplug via sysfs eject but
enables via ACPI notification?
Thanks,
-Toshi
next prev parent reply other threads:[~2013-11-18 18:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 23:14 [PATCH 0/3] ACPI hotplug fixes for 3.13 Rafael J. Wysocki
2013-11-13 23:15 ` [PATCH 1/3] ACPI / hotplug: Fix acpi_bus_get_device() return value check Rafael J. Wysocki
2013-11-18 18:03 ` Toshi Kani
2013-11-13 23:16 ` [PATCH 2/3] ACPI / hotplug: Fix PCI host bridge hot removal Rafael J. Wysocki
2013-11-18 18:10 ` Toshi Kani [this message]
2013-11-18 21:39 ` Rafael J. Wysocki
2013-11-18 23:13 ` Toshi Kani
2013-11-19 17:48 ` Toshi Kani
2013-11-19 21:10 ` Rafael J. Wysocki
2013-11-19 21:58 ` Toshi Kani
2013-11-19 23:42 ` Rafael J. Wysocki
2013-11-20 0:08 ` Rafael J. Wysocki
2013-11-20 1:22 ` Toshi Kani
2013-11-20 11:56 ` Rafael J. Wysocki
2013-11-20 15:36 ` Toshi Kani
2013-11-13 23:17 ` [PATCH 3/3] ACPI / PCI root: Clear driver_data before failing enumeration Rafael J. Wysocki
2013-11-18 18:10 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384798205.1791.14.camel@misato.fc.hp.com \
--to=toshi.kani@hp.com \
--cc=bhelgaas@google.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox