From: Toshi Kani <toshi.kani@hp.com>
To: Baoquan <bhe@redhat.com>
Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
Vivek Goyal <vgoyal@redhat.com>,
kexec@lists.infradead.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, tangchen@cn.fujitsu.com,
linux-acpi@vger.kernel.org, zhangyanfei@cn.fujitsu.com,
dyoung@redhat.com
Subject: Re: kdump failed because of hotplug memory adding in kdump kernel
Date: Fri, 10 Jan 2014 08:19:27 -0700 [thread overview]
Message-ID: <1389367167.1792.148.camel@misato.fc.hp.com> (raw)
In-Reply-To: <20140110091433.GA14074@dhcp-16-105.nay.redhat.com>
On Fri, 2014-01-10 at 17:14 +0800, Baoquan wrote:
:
> >
> > >Otherwise, any hotplug memory which is not reserved for 2nd kernel can
> > >be parsed and need be added as hotplug memory, and add them into movable
> > >zone.
> >
> > wrong.
> > The memory is allocated as normal zone and it is offline.
This is "logical" offline, which means that the memory is accessible,
but the 1st kernel does not use it.
> Hi,
>
> Thanks for answering.
>
> I am confused. Now the fact is in 1st kernel memory is reserved for
> crashkernel and passed to 2nd kernel by exactmap. Then in 2nd kernel,
> reserved memory regions are added into e820.
Right. And this memory is accessible.
> Later hotplug memory still
> trigger add_memory, and cause bug I reported.
This is because the 2nd kernel gets all memory ranges from ACPI without
your change. This is bad, not only it causes the panic you reported but
also it can overwrite the 1st kernel's memory.
Thanks,
-Toshi
next prev parent reply other threads:[~2014-01-10 15:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 15:26 kdump failed because of hotplug memory adding in kdump kernel Baoquan
[not found] ` <52CD6E33.400-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-08 15:58 ` Vivek Goyal
[not found] ` <20140108155829.GC13649-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-08 23:07 ` Rafael J. Wysocki
2014-01-09 0:11 ` Toshi Kani
2014-01-09 13:10 ` Rafael J. Wysocki
[not found] ` <1607377.rjs1kRTsnc-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2014-01-09 14:53 ` Vivek Goyal
[not found] ` <20140109145359.GC25897-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-09 16:15 ` Toshi Kani
2014-01-09 14:50 ` Vivek Goyal
2014-01-09 16:03 ` Toshi Kani
[not found] ` <1389283439.1792.66.camel-RbGIw1UOYPVo/CpIj0byZw@public.gmane.org>
2014-01-09 16:24 ` Vivek Goyal
[not found] ` <20140109162427.GF25897-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-09 17:24 ` Toshi Kani
[not found] ` <1389288265.1792.108.camel-RbGIw1UOYPVo/CpIj0byZw@public.gmane.org>
2014-01-09 18:23 ` Vivek Goyal
2014-01-09 18:34 ` Toshi Kani
[not found] ` <1389292470.1792.109.camel-RbGIw1UOYPVo/CpIj0byZw@public.gmane.org>
2014-01-09 21:27 ` Vivek Goyal
2014-01-09 21:56 ` Toshi Kani
2014-01-10 7:11 ` Baoquan
2014-01-10 8:06 ` Yasuaki Ishimatsu
[not found] ` <52CFAA20.2010109-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2014-01-10 9:14 ` Baoquan
2014-01-10 9:35 ` Yasuaki Ishimatsu
[not found] ` <52CFBECB.9040309-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2014-01-10 10:27 ` Baoquan
2014-01-10 15:19 ` Toshi Kani [this message]
2014-01-10 15:56 ` Toshi Kani
2014-01-10 1:40 ` Rafael J. Wysocki
2014-01-09 3:22 ` Baoquan
[not found] ` <8500545.JVNPnKcyD1-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2014-01-09 14:48 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389367167.1792.148.camel@misato.fc.hp.com \
--to=toshi.kani@hp.com \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kexec@lists.infradead.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tangchen@cn.fujitsu.com \
--cc=vgoyal@redhat.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).