From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: linux-acpi@vger.kernel.org
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Aaron Lu <aaron.lu@intel.com>,
linux-kernel@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: [PATCH] Revert "ACPI / video: Add HP EliteBook Revolve 810 to the blacklist"
Date: Fri, 14 Feb 2014 14:34:07 +0200 [thread overview]
Message-ID: <1392381247-28109-1-git-send-email-mika.westerberg@linux.intel.com> (raw)
This reverts commit e18ac62fa4b3f16234bab0d5a6627c57dbae9e7e.
The referenced commit added HP EliteBook Revolve 810 to the ACPI video
detected blacklist so that only the native Intel backlight interface was
exported.
However, this turned to be wrong solution after all. The ACPI video
interface works and as long as we only use that there are no problems. So
we can revert this commit and stick to use the backlight interface provided
by the ACPI video driver.
(Using Intel native interface will not work after resume since the ACPI
video driver will restore it's state which takes control over the native
one. That's a separate thing and should be addressed in the ACPI video
driver, I suppose.)
References: https://bugzilla.kernel.org/show_bug.cgi?id=70231
Cc: Aaron Lu <aaron.lu@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
Rafael,
This turned out to be misunderstanding from my side. I should have
investigated this further before submitting the original patch. Sorry about
that.
Aaron,
Thanks for the investigation and pointing me to the right direction (e.g to
use acpi_video0 over the native one).
drivers/acpi/video_detect.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index a697b77b8865..f0447d3daf2c 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -170,14 +170,6 @@ static struct dmi_system_id video_detect_dmi_table[] = {
},
{
.callback = video_detect_force_vendor,
- .ident = "HP EliteBook Revolve 810",
- .matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
- DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook Revolve 810 G1"),
- },
- },
- {
- .callback = video_detect_force_vendor,
.ident = "Lenovo Yoga 13",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
--
1.8.5.2
next reply other threads:[~2014-02-14 12:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 12:34 Mika Westerberg [this message]
2014-02-14 13:37 ` [PATCH] Revert "ACPI / video: Add HP EliteBook Revolve 810 to the blacklist" Takashi Iwai
2014-02-14 14:03 ` Mika Westerberg
2014-02-14 14:01 ` Takashi Iwai
2014-02-14 14:16 ` Mika Westerberg
2014-02-14 14:16 ` Takashi Iwai
2014-02-14 14:45 ` Mika Westerberg
2014-02-14 14:46 ` Takashi Iwai
2014-02-14 14:50 ` Aaron Lu
2014-02-14 14:54 ` Takashi Iwai
2014-02-14 15:26 ` Mika Westerberg
2014-02-14 22:21 ` Rafael J. Wysocki
2014-02-17 5:52 ` Aaron Lu
2014-02-17 9:56 ` Takashi Iwai
2014-02-17 13:07 ` Aaron Lu
2014-02-17 9:57 ` Mika Westerberg
2014-02-14 14:47 ` Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392381247-28109-1-git-send-email-mika.westerberg@linux.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=aaron.lu@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox