linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, imammedo@redhat.com, bp@suse.de,
	paul.gortmaker@windriver.com, JBeulich@suse.com,
	prarit@redhat.com, drjones@redhat.com, toshi.kani@hp.com,
	riel@redhat.com, gong.chen@linux.intel.com, andi@firstfloor.org,
	lenb@kernel.org, rjw@rjwysocki.net, linux-acpi@vger.kernel.org
Subject: [PATCH v3 4/5] x86: fix memory corruption in acpi_unmap_lsapic()
Date: Thu, 10 Apr 2014 19:14:20 +0200	[thread overview]
Message-ID: <1397150061-29735-5-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1397150061-29735-1-git-send-email-imammedo@redhat.com>

if during CPU hotplug master CPU failed to wake up AP
it set percpu x86_cpu_to_apicid to BAD_APICID=0xFFFF for AP.

However following attempt to unplug that CPU will lead to
out of bound write access to __apicid_to_node[] which is
32768 items long on x86_64 kernel.

So drop setting x86_cpu_to_apicid to BAD_APICID in do_boot_cpu()
and allow acpi_processor_remove()->acpi_unmap_lsapic() cleanly
remove CPU.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 arch/x86/kernel/smpboot.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index e7c15d7..44903ad 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -821,8 +821,6 @@ static int do_boot_cpu(int apicid, int cpu, struct task_struct *idle)
 			udelay(100);
 			schedule();
 		}
-	} else {
-		per_cpu(x86_cpu_to_apicid, cpu) = BAD_APICID;
 	}
 
 	/* mark "stuck" area as not stuck */
-- 
1.7.1

  parent reply	other threads:[~2014-04-10 17:14 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10 17:14 [PATCH v3 0/5] x86: fix hang when AP bringup is too slow Igor Mammedov
2014-04-10 17:14 ` [PATCH v3 1/5] x86: initialize secondary CPU only if master CPU will wait for it Igor Mammedov
2014-04-14  9:16   ` Ingo Molnar
2014-04-14  9:52     ` Igor Mammedov
2014-04-14 10:03       ` Ingo Molnar
2014-04-14 10:21         ` Igor Mammedov
2014-04-14 12:50         ` Igor Mammedov
2014-04-14 14:51           ` Ingo Molnar
2014-04-14 15:03             ` Igor Mammedov
2014-04-10 17:14 ` [PATCH v3 2/5] x86: log error on secondary CPU wakeup failure at ERR level Igor Mammedov
2014-04-10 17:14 ` [PATCH v3 3/5] x86: fix list corruption on CPU hotplug Igor Mammedov
2014-04-14  9:19   ` Ingo Molnar
2014-04-14  9:56     ` Igor Mammedov
2014-04-14 10:04       ` Ingo Molnar
2014-04-14 10:23         ` Igor Mammedov
2014-04-14 10:34           ` Ingo Molnar
2014-04-14 10:48             ` Igor Mammedov
2014-04-14 10:56               ` Ingo Molnar
2014-04-10 17:14 ` Igor Mammedov [this message]
2014-04-14  9:20   ` [PATCH v3 4/5] x86: fix memory corruption in acpi_unmap_lsapic() Ingo Molnar
2014-04-10 17:14 ` [PATCH v3 5/5] acpi_processor: do not mark present at boot but not onlined CPU as onlined Igor Mammedov
2014-04-14  9:21   ` Ingo Molnar
2014-04-15  5:36     ` Rafael J. Wysocki
2014-04-15  5:43   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397150061-29735-5-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=JBeulich@suse.com \
    --cc=andi@firstfloor.org \
    --cc=bp@suse.de \
    --cc=drjones@redhat.com \
    --cc=gong.chen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=prarit@redhat.com \
    --cc=riel@redhat.com \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    --cc=toshi.kani@hp.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).