From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toshi Kani Subject: Re: [PATCH v4 4/5] x86: log error on secondary CPU wakeup failure at ERR level Date: Wed, 30 Apr 2014 15:30:12 -0600 Message-ID: <1398893412.1789.48.camel@misato.fc.hp.com> References: <1397488277-14865-1-git-send-email-imammedo@redhat.com> <1397488277-14865-5-git-send-email-imammedo@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from g9t1613g.houston.hp.com ([15.240.0.71]:33790 "EHLO g9t1613g.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752219AbaD3Vjb (ORCPT ); Wed, 30 Apr 2014 17:39:31 -0400 In-Reply-To: <1397488277-14865-5-git-send-email-imammedo@redhat.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Igor Mammedov Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, bp@suse.de, paul.gortmaker@windriver.com, JBeulich@suse.com, prarit@redhat.com, drjones@redhat.com, riel@redhat.com, gong.chen@linux.intel.com, andi@firstfloor.org, lenb@kernel.org, rjw@rjwysocki.net, linux-acpi@vger.kernel.org On Mon, 2014-04-14 at 17:11 +0200, Igor Mammedov wrote: > If system is running without debug level logging, > it will not log error if do_boot_cpu() failed to > wakeup AP. It may lead to silent AP bringup > failures at boot time. > Change message level to KERN_ERR to make error > visible to user as it's done on other architectures. > > Signed-off-by: Igor Mammedov > --- > arch/x86/kernel/smpboot.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c > index 2988f69..ae2fd97 100644 > --- a/arch/x86/kernel/smpboot.c > +++ b/arch/x86/kernel/smpboot.c > @@ -918,7 +918,7 @@ int native_cpu_up(unsigned int cpu, struct task_struct *tidle) > > err = do_boot_cpu(apicid, cpu, tidle); > if (err) { > - pr_debug("do_boot_cpu failed %d\n", err); > + pr_err("do_boot_cpu failed(%d) to wakeup CPU#%u\n", err, cpu); > return -EIO; > } > Looks good. Acked-by: Toshi Kani I will review patch 5/5 later (probably tomorrow). Thanks, -Toshi