[PATCH] ACPI / platform: add IDs for Broadcom Bluetooth and GPS chips

[PATCH] ACPI / platform: add IDs for Broadcom Bluetooth and GPS chips

[Heikki Krogerus]

These IDs are used on Baytrail boards such as Lenovo Miix 2
and Asus Transformer Book T100TA. On lenovo Miix 2 8",
BCM4752 is called LNV4752. All the rest of the IDs are for
Broadcom BCM43241 module with the ID referring to different
revision number.

Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
 drivers/acpi/acpi_platform.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
index 1d49503..34a64c5 100644
--- a/drivers/acpi/acpi_platform.c
+++ b/drivers/acpi/acpi_platform.c
@@ -31,6 +31,10 @@ static const struct acpi_device_id acpi_platform_device_ids[] = {
 	{ "PNP0D40" },
 	{ "VPC2004" },
 	{ "BCM4752" },
+	{ "LNV4752" },
+	{ "BCM2E1A" },
+	{ "BCM2E39" },
+	{ "BCM2E3D" },
 
 	/* Intel Smart Sound Technology */
 	{ "INT33C8" },
-- 
2.0.0.rc2

Re: [PATCH] ACPI / platform: add IDs for Broadcom Bluetooth and GPS chips

[Rolf Eike Beer]

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]

Am Donnerstag, 8. Mai 2014, 14:59:04 schrieb Heikki Krogerus:
> These IDs are used on Baytrail boards such as Lenovo Miix 2
> and Asus Transformer Book T100TA. On lenovo Miix 2 8",
> BCM4752 is called LNV4752. All the rest of the IDs are for
> Broadcom BCM43241 module with the ID referring to different
> revision number.

Hi,

the AzureWave AW-AH691A module looks similar to me, it is identified as 
AAM4752. However if I add it to that list I don't get anything, even with the 
brcmfmac driver loaded. Is there any magic missing?

Greetings,

Eike
-- 
Rolf Eike Beer, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11
Bertha-von-Suttner-Str. 9, 37085 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführung: Dr. Uwe Kracke, Ust-IdNr.: DE 205 198 055

emlix - smart embedded open source

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 316 bytes --]

Re: [PATCH] ACPI / platform: add IDs for Broadcom Bluetooth and GPS chips

[Heikki Krogerus]

Hi Rolf,

On Tue, May 13, 2014 at 03:14:01PM +0200, Rolf Eike Beer wrote:
> Am Donnerstag, 8. Mai 2014, 14:59:04 schrieb Heikki Krogerus:
> > These IDs are used on Baytrail boards such as Lenovo Miix 2
> > and Asus Transformer Book T100TA. On lenovo Miix 2 8",
> > BCM4752 is called LNV4752. All the rest of the IDs are for
> > Broadcom BCM43241 module with the ID referring to different
> > revision number.
> 
> the AzureWave AW-AH691A module looks similar to me, it is identified as 
> AAM4752. However if I add it to that list I don't get anything, even with the 
> brcmfmac driver loaded. Is there any magic missing?

Which machine are you using? Could you attach the output of acpidump?

Thanks,

-- 
heikki

Re: [PATCH] ACPI / platform: add IDs for Broadcom Bluetooth and GPS chips

[Rolf Eike Beer]

[-- Attachment #1: Type: text/plain, Size: 1337 bytes --]

Heikki Krogerus wrote:
> Hi Rolf,
> 
> On Tue, May 13, 2014 at 03:14:01PM +0200, Rolf Eike Beer wrote:
> > Am Donnerstag, 8. Mai 2014, 14:59:04 schrieb Heikki Krogerus:
> > > These IDs are used on Baytrail boards such as Lenovo Miix 2
> > > and Asus Transformer Book T100TA. On lenovo Miix 2 8",
> > > BCM4752 is called LNV4752. All the rest of the IDs are for
> > > Broadcom BCM43241 module with the ID referring to different
> > > revision number.
> > 
> > the AzureWave AW-AH691A module looks similar to me, it is identified as
> > AAM4752. However if I add it to that list I don't get anything, even with
> > the brcmfmac driver loaded. Is there any magic missing?
> 
> Which machine are you using? Could you attach the output of acpidump?

Hi Heikki,

this is an Aava Inari 8 tablet (pre-release hardware). To avoid spamming the 
list with the same DSDT twice, please have a look at my reply in the thread 
"Re: [Patch V2 0/9] I2C ACPI operation region handler support".

Greetings,

Eike
-- 
Rolf Eike Beer, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11
Bertha-von-Suttner-Str. 9, 37085 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführung: Dr. Uwe Kracke, Ust-IdNr.: DE 205 198 055

emlix - smart embedded open source

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 316 bytes --]

Re: [PATCH] ACPI / platform: add IDs for Broadcom Bluetooth and GPS chips

[Heikki Krogerus]

Hi,

On Thu, May 15, 2014 at 09:50:45AM +0200, Rolf Eike Beer wrote:
> Heikki Krogerus wrote:
> > > the AzureWave AW-AH691A module looks similar to me, it is identified as
> > > AAM4752. However if I add it to that list I don't get anything, even with
> > > the brcmfmac driver loaded. Is there any magic missing?
> > 
> > Which machine are you using? Could you attach the output of acpidump?
> 
> this is an Aava Inari 8 tablet (pre-release hardware). To avoid spamming the 
> list with the same DSDT twice, please have a look at my reply in the thread 
> "Re: [Patch V2 0/9] I2C ACPI operation region handler support".

Okay. So the AAM4752 is a GPS module attached to the UART. You need
to add the HID to the list in drivers/acpi/acpi_platform.c and also to
the driver, which is net/rfkill/rfkill-gpio.c in this case.

But that will only give you a rfkill switch that allows you to
control the enable signal of the chip via rfkill framework. The actual
communication with the chip happens from userspace via /dev/ttySx
(/dev/ttyS2 on your board), just like with any other peripheral
attached to UARTs. So no drivers needed for that.


Br,

-- 
heikki

Re: [PATCH] ACPI / platform: add IDs for Broadcom Bluetooth and GPS chips

[Rafael J. Wysocki]

On Thursday, May 08, 2014 02:59:04 PM Heikki Krogerus wrote:
> These IDs are used on Baytrail boards such as Lenovo Miix 2
> and Asus Transformer Book T100TA. On lenovo Miix 2 8",
> BCM4752 is called LNV4752. All the rest of the IDs are for
> Broadcom BCM43241 module with the ID referring to different
> revision number.
> 
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

Queued up for 3.16, thanks!

> ---
>  drivers/acpi/acpi_platform.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
> index 1d49503..34a64c5 100644
> --- a/drivers/acpi/acpi_platform.c
> +++ b/drivers/acpi/acpi_platform.c
> @@ -31,6 +31,10 @@ static const struct acpi_device_id acpi_platform_device_ids[] = {
>  	{ "PNP0D40" },
>  	{ "VPC2004" },
>  	{ "BCM4752" },
> +	{ "LNV4752" },
> +	{ "BCM2E1A" },
> +	{ "BCM2E39" },
> +	{ "BCM2E3D" },
>  
>  	/* Intel Smart Sound Technology */
>  	{ "INT33C8" },
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.