From: "Zhang, Rui" <rui.zhang@intel.com>
To: "mochs@nvidia.com" <mochs@nvidia.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"lenb@kernel.org" <lenb@kernel.org>,
"erik.kaneda@intel.com" <erik.kaneda@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"Ko, Koba" <kobak@nvidia.com>
Subject: Re: [PATCH] acpi/prmt: find block with specific type
Date: Wed, 21 Aug 2024 06:48:59 +0000 [thread overview]
Message-ID: <13f458859adcb75d0930f1a76d7c0e2f74f5e7d5.camel@intel.com> (raw)
In-Reply-To: <519e8e00-cd82-485f-8871-81fb703c7592@nvidia.com>
On Wed, 2024-08-21 at 14:36 +0800, Koba Ko wrote:
>
> On 8/21/24 14:33, Zhang, Rui wrote:
> > Yeah, but I mean pr_err() may be overkill if the driver is still
> > functional.
>
> how about replace with pr_warn?
when it fails,
1. the address space handler still returns AE_OK (is it right?)
2. I don't see how PRM_HANDLER_GUID_NOT_FOUND prm_status is handled
So, if it is a critical error, we should fail the prmt probe
immediately.
If it is not, we can let space handler returns AE_OK like you do in
this patch, and in this case, even a pr_info() is sufficient IMV.
thanks,
rui
next prev parent reply other threads:[~2024-08-21 6:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 1:48 [PATCH] acpi/prmt: find block with specific type KobaK
2024-08-21 3:20 ` Zhang, Rui
2024-08-21 4:01 ` Koba Ko
2024-08-21 4:55 ` Zhang, Rui
2024-08-21 5:48 ` Koba Ko
2024-08-21 6:33 ` Zhang, Rui
2024-08-21 6:36 ` Koba Ko
2024-08-21 6:48 ` Zhang, Rui [this message]
2024-08-21 7:03 ` Koba Ko
2024-08-21 7:55 ` Koba Ko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13f458859adcb75d0930f1a76d7c0e2f74f5e7d5.camel@intel.com \
--to=rui.zhang@intel.com \
--cc=erik.kaneda@intel.com \
--cc=james.morse@arm.com \
--cc=kobak@nvidia.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mochs@nvidia.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox