From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toshi Kani Subject: Re: [PATCH] ACPI/hotplug: Fix STARTING/DYING action in acpi_cpu_soft_notify() Date: Mon, 19 May 2014 16:57:02 -0600 Message-ID: <1400540222.18128.6.camel@misato.fc.hp.com> References: <1399557539-7282-1-git-send-email-toshi.kani@hp.com> <2011129.WMiXDPUasW@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from g4t3425.houston.hp.com ([15.201.208.53]:31535 "EHLO g4t3425.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981AbaESXFr (ORCPT ); Mon, 19 May 2014 19:05:47 -0400 In-Reply-To: <2011129.WMiXDPUasW@vostro.rjw.lan> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, 2014-05-20 at 00:55 +0200, Rafael J. Wysocki wrote: > On Thursday, May 08, 2014 07:58:59 AM Toshi Kani wrote: > > During CPU online/offline testing on a large system, one of the > > processors got stuck after the message "bad: scheduling from the > > idle thread!". The problem is that acpi_cpu_soft_notify() calls > > acpi_bus_get_device() for all action types. CPU_STARTING and > > CPU_DYING do not allow the notify handlers to sleep. However, > > acpi_bus_get_device() can sleep in acpi_ut_acquire_mutex(). > > > > Change acpi_cpu_soft_notify() to return immediately for CPU_STARTING > > and CPU_DYING as they have no action in this handler. > > > > Signed-off-by: Toshi Kani > > Queued up for 3.16, thanks! Great! Thanks Rafael! -Toshi