Linux ACPI
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux ACPI <linux-acpi@vger.kernel.org>,
	Hans de Goede <hansg@kernel.org>,
	platform-driver-x86@vger.kernel.org,
	Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Subject: [PATCH v1 01/10] platform/x86: classmate-laptop: Address memory leaks on driver removal
Date: Thu, 07 May 2026 22:00:11 +0200	[thread overview]
Message-ID: <14005591.uLZWGnKmhe@rafael.j.wysocki> (raw)
In-Reply-To: <1956046.tdWV9SEqCh@rafael.j.wysocki>

From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>

Update cmpc_accel_remove_v4() and cmpc_accel_remove() to free memory
allocated in cmpc_accel_add_v4() and cmpc_accel_add(), respectively.

Fixes: 529aa8cb0a59 ("classmate-laptop: add support for Classmate PC ACPI devices")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/platform/x86/classmate-laptop.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
index e6eed3d65580..218834ddddc3 100644
--- a/drivers/platform/x86/classmate-laptop.c
+++ b/drivers/platform/x86/classmate-laptop.c
@@ -441,9 +441,13 @@ static int cmpc_accel_add_v4(struct acpi_device *acpi)
 
 static void cmpc_accel_remove_v4(struct acpi_device *acpi)
 {
+	struct input_dev *inputdev = dev_get_drvdata(&acpi->dev);
+	struct cmpc_accel *accel = dev_get_drvdata(&inputdev->dev);
+
 	device_remove_file(&acpi->dev, &cmpc_accel_sensitivity_attr_v4);
 	device_remove_file(&acpi->dev, &cmpc_accel_g_select_attr_v4);
 	cmpc_remove_acpi_notify_device(acpi);
+	kfree(accel);
 }
 
 static SIMPLE_DEV_PM_OPS(cmpc_accel_pm, cmpc_accel_suspend_v4,
@@ -680,8 +684,12 @@ static int cmpc_accel_add(struct acpi_device *acpi)
 
 static void cmpc_accel_remove(struct acpi_device *acpi)
 {
+	struct input_dev *inputdev = dev_get_drvdata(&acpi->dev);
+	struct cmpc_accel *accel = dev_get_drvdata(&inputdev->dev);
+
 	device_remove_file(&acpi->dev, &cmpc_accel_sensitivity_attr);
 	cmpc_remove_acpi_notify_device(acpi);
+	kfree(accel);
 }
 
 static const struct acpi_device_id cmpc_accel_device_ids[] = {




  reply	other threads:[~2026-05-07 20:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07 19:58 [PATCH v1 00/10] platform/x86: classmate-laptop: Bind to platform devices instead of ACPI ones Rafael J. Wysocki
2026-05-07 20:00 ` Rafael J. Wysocki [this message]
2026-05-07 20:01 ` [PATCH v1 02/10] platform/x86: classmate-laptop: Unify probe rollback and remove code Rafael J. Wysocki
2026-05-07 20:03 ` [PATCH v1 03/10] platform/x86: classmate-laptop: Pass struct device pointer to helpers Rafael J. Wysocki
2026-05-07 20:04 ` [PATCH v1 04/10] platform/x86: classmate-laptop: Rename two helper functions Rafael J. Wysocki
2026-05-07 20:07 ` [PATCH v1 05/10] platform/x86: classmate-laptop: Register ACPI notify handlers directly Rafael J. Wysocki
2026-05-07 20:10 ` [PATCH v1 06/10] platform/x86: classmate-laptop: Convert v4 accel driver to a platform one Rafael J. Wysocki
2026-05-07 20:10 ` [PATCH v1 07/10] platform/x86: classmate-laptop: Convert " Rafael J. Wysocki
2026-05-07 20:11 ` [PATCH v1 08/10] platform/x86: classmate-laptop: Convert tablet " Rafael J. Wysocki
2026-05-07 20:12 ` [PATCH v1 09/10] platform/x86: classmate-laptop: Convert ipml " Rafael J. Wysocki
2026-05-07 20:14 ` [PATCH v1 10/10] platform/x86: classmate-laptop: Convert keys " Rafael J. Wysocki
2026-05-08 12:05 ` [PATCH v1 00/10] platform/x86: classmate-laptop: Bind to platform devices instead of ACPI ones Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14005591.uLZWGnKmhe@rafael.j.wysocki \
    --to=rafael@kernel.org \
    --cc=cascardo@holoscopio.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox