From: Joe Perches <joe@perches.com>
To: Arjun Sreedharan <arjun024@gmail.com>
Cc: rjw@rjwysocki.net, lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: fix test for hex digit.
Date: Wed, 30 Jul 2014 13:00:12 -0700 [thread overview]
Message-ID: <1406750412.12100.65.camel@joe-AO725> (raw)
In-Reply-To: <1406749932-1709-1-git-send-email-arjun024@gmail.com>
On Thu, 2014-07-31 at 01:22 +0530, Arjun Sreedharan wrote:
> decimal 0 is ascii for NULL. Hex digit matching should be from '0'
> (decimal 30 of ascii) to '9' and 'A' to 'F'.
> Unfixed version returns true for #,$,%,& etc.
[]
> diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c
[]
> @@ -322,7 +322,7 @@ static const struct acpi_device_id acpi_pnp_device_ids[] = {
>
> static bool is_hex_digit(char c)
> {
> - return (c >= 0 && c <= '9') || (c >= 'A' && c <= 'F');
> + return (c >= '0' && c <= '9') || (c >= 'A' && c <= 'F');
> }
Maybe delete this and do s/is_hex_digit/isxdigit/ ?
next prev parent reply other threads:[~2014-07-30 20:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 19:52 [PATCH] ACPI: fix test for hex digit Arjun Sreedharan
2014-07-30 20:00 ` Joe Perches [this message]
2014-07-31 0:05 ` [PATCH] Replace faulty is_hex_digit() by isxdigit() Arjun Sreedharan
2014-07-31 0:10 ` Randy Dunlap
2014-07-31 9:04 ` Arjun Sreedharan
2014-07-31 16:31 ` Randy Dunlap
2014-07-31 22:31 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406750412.12100.65.camel@joe-AO725 \
--to=joe@perches.com \
--cc=arjun024@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox