From: Sudeep Holla <sudeep.holla@arm.com>
To: linux-acpi@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: [PATCH 1/3] ACPI / processor: remove incorrect comparison of phys_id
Date: Tue, 25 Nov 2014 14:48:48 +0000 [thread overview]
Message-ID: <1416926930-792-2-git-send-email-sudeep.holla@arm.com> (raw)
In-Reply-To: <1416926930-792-1-git-send-email-sudeep.holla@arm.com>
phys_id in acpi_processor structure is unsigned 32-bit integer,
comparing it with signed value is incorrect.
This patch removes that incorrect comparision in acpi_processor_hotadd_init
as the lone user of this function is already checking for correctness
of phys_id before calling it.
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/acpi/acpi_processor.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c
index c4a8a5666298..eaf56f6ce1eb 100644
--- a/drivers/acpi/acpi_processor.c
+++ b/drivers/acpi/acpi_processor.c
@@ -170,9 +170,6 @@ static int acpi_processor_hotadd_init(struct acpi_processor *pr)
acpi_status status;
int ret;
- if (pr->phys_id == -1)
- return -ENODEV;
-
status = acpi_evaluate_integer(pr->handle, "_STA", NULL, &sta);
if (ACPI_FAILURE(status) || !(sta & ACPI_STA_DEVICE_PRESENT))
return -ENODEV;
--
1.9.1
next prev parent reply other threads:[~2014-11-25 15:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 14:48 [PATCH 0/3] ACPI/processor: trivial fixes Sudeep Holla
2014-11-25 14:48 ` Sudeep Holla [this message]
2014-11-25 23:11 ` [PATCH 1/3] ACPI / processor: remove incorrect comparison of phys_id Rafael J. Wysocki
2014-11-26 12:23 ` Sudeep Holla
2014-11-26 9:53 ` Hanjun Guo
2014-11-26 10:33 ` Sudeep Holla
2014-11-26 22:26 ` Rafael J. Wysocki
2014-11-27 2:43 ` Hanjun Guo
2014-11-28 19:05 ` Sudeep Holla
2014-11-28 23:26 ` Rafael J. Wysocki
2015-02-13 7:56 ` Hanjun Guo
2015-02-16 10:08 ` Sudeep Holla
2015-02-17 15:01 ` Hanjun Guo
2015-02-17 15:20 ` Sudeep Holla
2014-11-25 14:48 ` [PATCH 2/3] ACPI / processor: remove unused variabled from acpi_processor_power structure Sudeep Holla
2014-11-25 14:48 ` [PATCH 3/3] ACPI / cpuidle: avoid assigning signed errno to acpi_status Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416926930-792-2-git-send-email-sudeep.holla@arm.com \
--to=sudeep.holla@arm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox