From: Hans de Goede <hdegoede@redhat.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Aaron Lu <aaron.lu@intel.com>, Zhang Rui <rui.zhang@intel.com>,
linux-acpi@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>
Subject: [RFC PATCH 2/2] acpi: video: Add force native backlight quirk for Lenovo Ideapad Z570
Date: Tue, 3 Mar 2015 08:39:10 +0100 [thread overview]
Message-ID: <1425368350-4028-3-git-send-email-hdegoede@redhat.com> (raw)
In-Reply-To: <1425368350-4028-1-git-send-email-hdegoede@redhat.com>
The Lenovo Ideapad Z570 (which is an Acer in disguise like some other Ideapads)
has a broken acpi_video interface and is too old for the acpi-video code to
automatically prefer the native backlight interface, so add a quirk for it.
Note that this cannot be done with a quirk in the vendor backlight driver as
is the normal way to fix this as the Z570 offers both acer-wmi and
ideapad-laptop vendor backlight interfaces, so this would require the same
quirk in 2 places which is the wrong thing to do.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1187004
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/acpi/video.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 9817b52..70a7ec3 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -419,6 +419,12 @@ static int __init video_disable_native_backlight(const struct dmi_system_id *d)
return 0;
}
+static int __init video_force_native_backlight(const struct dmi_system_id *d)
+{
+ use_native_backlight_dmi = 2;
+ return 0;
+}
+
static struct dmi_system_id video_dmi_table[] __initdata = {
/*
* Broken _BQC workaround http://bugzilla.kernel.org/show_bug.cgi?id=13121
@@ -560,6 +566,17 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
DMI_MATCH(DMI_PRODUCT_NAME, "XPS L521X"),
},
},
+
+ /* Non win8 machines which need native backlight nevertheless */
+ {
+ /* https://bugzilla.redhat.com/show_bug.cgi?id=1187004 */
+ .callback = video_force_native_backlight,
+ .ident = "Lenovo Ideapad Z570",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "102434U"),
+ },
+ },
{}
};
--
2.3.1
next prev parent reply other threads:[~2015-03-03 7:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 7:39 [RFC PATCH 0/2] acpi: video: Allow forcing native backlight on non win8 laptops Hans de Goede
2015-03-03 7:39 ` [RFC PATCH 1/2] acpi: video: Allow forcing native backlight on non win8 machines Hans de Goede
2015-03-03 8:26 ` Aaron Lu
2015-03-03 13:11 ` Hans de Goede
2015-03-04 2:50 ` Aaron Lu
2015-03-10 22:25 ` Rafael J. Wysocki
2015-03-10 22:42 ` Hans de Goede
2015-03-10 23:10 ` Rafael J. Wysocki
2015-03-11 6:14 ` [PATCH update] acpi: video: Allow forcing native backlight on non win8, machines Aaron Lu
2015-03-11 11:14 ` Hans de Goede
2015-03-11 13:05 ` Aaron Lu
2015-03-12 22:40 ` Rafael J. Wysocki
2015-03-03 7:39 ` Hans de Goede [this message]
2015-03-10 22:26 ` [RFC PATCH 2/2] acpi: video: Add force native backlight quirk for Lenovo Ideapad Z570 Rafael J. Wysocki
2015-03-10 22:44 ` Hans de Goede
2015-03-03 8:25 ` [RFC PATCH 0/2] acpi: video: Allow forcing native backlight on non win8 laptops Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425368350-4028-3-git-send-email-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=aaron.lu@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).