From: Borislav Petkov <bp@alien8.de>
To: linux-edac <linux-edac@vger.kernel.org>
Cc: Borislav Petkov <bp@suse.de>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Tony Luck <tony.luck@intel.com>,
Tomasz Nowicki <tomasz.nowicki@linaro.org>,
"Chen, Gong" <gong.chen@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>, Lv Zheng <lv.zheng@intel.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH 4/5] GHES: Elliminate double-loop in the NMI handler
Date: Fri, 27 Mar 2015 10:22:57 +0100 [thread overview]
Message-ID: <1427448178-20689-5-git-send-email-bp@alien8.de> (raw)
In-Reply-To: <1427448178-20689-1-git-send-email-bp@alien8.de>
From: Borislav Petkov <bp@suse.de>
There's no real need to iterate twice over the HW error sources in the
NMI handler. With the previous cleanups, elliminating the second loop is
almost trivial.
Signed-off-by: Borislav Petkov <bp@suse.de>
---
drivers/acpi/apei/ghes.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index 0de3adcca03e..94a44bad5576 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -851,25 +851,18 @@ static int ghes_notify_nmi(unsigned int cmd, struct pt_regs *regs)
if (sev >= GHES_SEV_PANIC)
__ghes_panic(ghes);
- ret = NMI_HANDLED;
- }
-
- if (ret == NMI_DONE)
- goto out;
-
- list_for_each_entry_rcu(ghes, &ghes_nmi, list) {
if (!(ghes->flags & GHES_TO_CLEAR))
continue;
__process_error(ghes);
ghes_clear_estatus(ghes);
+
+ ret = NMI_HANDLED;
}
#ifdef CONFIG_ARCH_HAVE_NMI_SAFE_CMPXCHG
irq_work_queue(&ghes_proc_irq_work);
#endif
-
-out:
raw_spin_unlock(&ghes_nmi_lock);
return ret;
}
--
2.3.3
next prev parent reply other threads:[~2015-03-27 9:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 9:22 [RFC PATCH 0/5] GHES NMI handler cleanup Borislav Petkov
2015-03-27 9:22 ` [RFC PATCH 1/5] GHES: Carve out error queueing in a separate function Borislav Petkov
2015-03-27 9:22 ` [RFC PATCH 2/5] GHES: Carve out the panic functionality Borislav Petkov
2015-03-27 9:22 ` [RFC PATCH 3/5] GHES: Panic right after detection Borislav Petkov
2015-03-27 9:22 ` Borislav Petkov [this message]
2015-03-27 9:22 ` [RFC PATCH 5/5] GHES: Make NMI handler have a single reader Borislav Petkov
2015-04-01 7:45 ` Jiri Kosina
2015-04-01 13:49 ` Borislav Petkov
2015-04-23 8:39 ` Jiri Kosina
2015-04-23 8:59 ` Borislav Petkov
2015-04-23 18:00 ` Luck, Tony
2015-04-27 20:23 ` Borislav Petkov
2015-04-28 14:30 ` Don Zickus
2015-04-28 14:42 ` Don Zickus
2015-04-28 14:55 ` Borislav Petkov
2015-04-28 15:35 ` Don Zickus
2015-04-28 16:22 ` Borislav Petkov
2015-04-28 18:44 ` Don Zickus
2015-05-04 15:40 ` Borislav Petkov
2015-04-27 3:16 ` Zheng, Lv
2015-04-27 8:46 ` Borislav Petkov
2015-04-28 0:44 ` Zheng, Lv
2015-04-28 2:24 ` Zheng, Lv
2015-04-28 7:38 ` Borislav Petkov
2015-04-28 13:38 ` Zheng, Lv
2015-04-28 13:59 ` Borislav Petkov
2015-04-29 0:24 ` Zheng, Lv
2015-04-29 0:49 ` Zheng, Lv
2015-04-29 8:13 ` Borislav Petkov
2015-04-30 8:05 ` Zheng, Lv
2015-04-30 8:48 ` Borislav Petkov
2015-05-02 0:34 ` Zheng, Lv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427448178-20689-5-git-send-email-bp@alien8.de \
--to=bp@alien8.de \
--cc=bp@suse.de \
--cc=gong.chen@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rjw@rjwysocki.net \
--cc=tomasz.nowicki@linaro.org \
--cc=tony.luck@intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).