Re: [PATCH 29/32] thinkpad-acpi: Port to new backlight interface selection API

From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Hans de Goede <hdegoede@redhat.com>,
	Darren Hart <dvhart@infradead.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "Matthew Garrett" <mjg59@srcf.ucam.org>,
	"Ike Panhc" <ike.pan@canonical.com>,
	linux-acpi@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net,
	acpi4asus-user@lists.sourceforge.net,
	dri-devel@lists.freedesktop.org,
	"Azael Avalos" <coproscefalo@gmail.com>,
	"Lee Chun-Yi" <jlee@suse.com>,
	"Mattia Dongili" <malattia@linux.it>,
	"Cezary Jackiewicz" <cezary.jackiewicz@gmail.com>,
	"Ben Skeggs" <bskeggs@redhat.com>,
	"Corentin Chary" <corentin.chary@gmail.com>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	platform-driver-x86@vger.kernel.org,
	"Aaron Lu" <aaron.lu@intel.com>
Subject: Re: [PATCH 29/32] thinkpad-acpi: Port to new backlight interface selection API
Date: Wed, 10 Jun 2015 10:59:04 -0300	[thread overview]
Message-ID: <1433944744.203111.291880497.150C6869@webmail.messagingengine.com> (raw)
In-Reply-To: <1433941292-21530-30-git-send-email-hdegoede@redhat.com>

On Wed, Jun 10, 2015, at 10:01, Hans de Goede wrote:
> Port the backlight selection logic to the new backlight interface
> selection API.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>

> ---
>  drivers/platform/x86/thinkpad_acpi.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/thinkpad_acpi.c
> b/drivers/platform/x86/thinkpad_acpi.c
> index 28f3281..33e488c 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -83,6 +83,7 @@
>  #include <sound/control.h>
>  #include <sound/initval.h>
>  #include <asm/uaccess.h>
> +#include <acpi/video.h>
>  
>  /* ThinkPad CMOS commands */
>  #define TP_CMOS_VOLUME_DOWN     0
> @@ -3487,7 +3488,7 @@ static int __init hotkey_init(struct
> ibm_init_struct *iibm)
>  	/* Do not issue duplicate brightness change events to
>  	 * userspace. tpacpi_detect_brightness_capabilities() must have
>  	 * been called before this point  */
> -       if (acpi_video_backlight_support()) {
> +       if (acpi_video_get_backlight_type() != acpi_backlight_vendor) {
>  		pr_info("This ThinkPad has standard ACPI backlight "
>  			"brightness control, supported by the ACPI "
>  			"video driver\n");
> @@ -6491,7 +6492,7 @@ static int __init brightness_init(struct
> ibm_init_struct *iibm)
>  		return 1;
>  	}
>  
> -       if (acpi_video_backlight_support()) {
> +       if (acpi_video_get_backlight_type() != acpi_backlight_vendor) {
>  		if (brightness_enable > 1) {
>  			pr_info("Standard ACPI backlight interface "
>  				"available, not loading native one\n");
> -- 
> 2.4.2

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel