From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Vinod Koul <vinod.koul@intel.com>,
Lee Jones <lee.jones@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
Mike Turquette <mturquette@linaro.org>
Subject: Re: [PATCH v3 3/8] Driver core: wakeup the parent device before trying probe
Date: Wed, 10 Jun 2015 17:02:21 +0300 [thread overview]
Message-ID: <1433944941.26331.119.camel@linux.intel.com> (raw)
In-Reply-To: <3252449.XN2pzxrAPQ@vostro.rjw.lan>
On Wed, 2015-06-10 at 02:08 +0200, Rafael J. Wysocki wrote:
> On Tuesday, June 09, 2015 01:42:00 AM Rafael J. Wysocki wrote:
> > On Monday, June 01, 2015 05:47:57 PM Andy Shevchenko wrote:
> > > From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > >
> > > If the parent is still suspended when driver probe is
> > > attempted, the result may be failure.
> > >
> > > For example, if the parent is a PCI MFD device that has been
> > > suspended when we try to probe our device, any register
> > > reads will return 0xffffffff.
> > >
> > > To fix the problem, making sure the parent is always awake
> > > before attempting driver probe.
[]
> Actually, something like the below should work too (the bumping up of the
> parent's usage counter before the loop will keep it in the runtime-active
> state throughout the loop).
It works. Thanks for the patch. We incorporate it instead of the
previous Heikki's patch into v4.
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2015-06-10 14:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 14:47 [PATCH v3 0/8] mfd: introduce a driver for LPSS devices on SPT Andy Shevchenko
2015-06-01 14:47 ` [PATCH v3 1/8] PM / QoS: Make it possible to expose device latency tolerance to userspace Andy Shevchenko
2015-06-10 23:41 ` Rafael J. Wysocki
2015-06-01 14:47 ` [PATCH v3 2/8] ACPI / PM: Attach ACPI power domain only once Andy Shevchenko
2015-06-10 23:41 ` Rafael J. Wysocki
2015-06-01 14:47 ` [PATCH v3 3/8] Driver core: wakeup the parent device before trying probe Andy Shevchenko
2015-06-08 23:42 ` Rafael J. Wysocki
2015-06-10 0:08 ` Rafael J. Wysocki
2015-06-10 9:43 ` Andy Shevchenko
2015-06-10 23:41 ` Rafael J. Wysocki
2015-06-10 14:02 ` Andy Shevchenko [this message]
2015-06-01 14:47 ` [PATCH v3 4/8] klist: implement klist_prev() Andy Shevchenko
2015-06-01 14:47 ` [PATCH v3 5/8] driver core: implement device_for_each_child_reverse() Andy Shevchenko
2015-06-01 14:48 ` [PATCH v3 6/8] mfd: make mfd_remove_devices() iterate in reverse order Andy Shevchenko
2015-06-01 14:48 ` [PATCH v3 7/8] dmaengine: add a driver for Intel integrated DMA 64-bit Andy Shevchenko
2015-06-01 14:48 ` [PATCH v3 8/8] mfd: Add support for Intel Sunrisepoint LPSS devices Andy Shevchenko
2015-06-02 9:44 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433944941.26331.119.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mturquette@linaro.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).