From: Hans de Goede <hdegoede@redhat.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Darren Hart <dvhart@infradead.org>
Cc: "Aaron Lu" <aaron.lu@intel.com>,
"Ben Skeggs" <bskeggs@redhat.com>, "Lee Chun-Yi" <jlee@suse.com>,
"Peter Feuerer" <peter@piie.net>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Cezary Jackiewicz" <cezary.jackiewicz@gmail.com>,
"Matthew Garrett" <mjg59@srcf.ucam.org>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Jonathan Woithe" <jwoithe@just42.net>,
"Ike Panhc" <ike.pan@canonical.com>,
"Anisse Astier" <anisse@astier.eu>,
"Henrique de Moraes Holschuh" <ibm-acpi@hmh.eng.br>,
"Azael Avalos" <coproscefalo@gmail.com>,
linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
acpi4asus-user@lists.sourceforge.net,
ibm-acpi-devel@lists.sourceforge.net,
"Hans de Goede" <hdegoede@redhat.com>
Subject: [PATCH v3 11/35] acpi-video-detect: Unregister acpi_video backlight when dmi quirks are added
Date: Tue, 16 Jun 2015 16:27:49 +0200 [thread overview]
Message-ID: <1434464893-3529-12-git-send-email-hdegoede@redhat.com> (raw)
In-Reply-To: <1434464893-3529-1-git-send-email-hdegoede@redhat.com>
Make acpi_video_set_dmi_backlight_type() call
acpi_video_unregister_backlight() when the new dmi quirk results in
the desired backlight interface being of a type other then
acpi_backlight_video.
This avoid the need for the second if in the following construction
which is currently found in many platform/x86 drivers:
if (prefer_vendor_quirk)
acpi_video_dmi_promote_vendor();
if (!acpi_video_backlight_support())
acpi_video_unregister_backlight()
This second if-block will be removed from the platform drivers as part
of their conversion to the new backlight interface selection API.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/acpi/video_detect.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 0f9586b..d00c0f4 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -183,6 +183,9 @@ EXPORT_SYMBOL(acpi_video_get_backlight_type);
void acpi_video_set_dmi_backlight_type(enum acpi_backlight_type type)
{
acpi_backlight_dmi = type;
+ /* Remove acpi-video backlight interface if it is no longer desired */
+ if (acpi_video_get_backlight_type() != acpi_backlight_video)
+ acpi_video_unregister_backlight();
}
EXPORT_SYMBOL(acpi_video_set_dmi_backlight_type);
--
2.3.6
next prev parent reply other threads:[~2015-06-16 14:27 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 14:27 [PATCH v3 00/35] acpi-video: Rewrite backlight interface selection logic Hans de Goede
2015-06-16 14:27 ` [PATCH v3 01/35] apple_gmux: Use acpi_video_unregister_backlight instead of acpi_video_unregister Hans de Goede
2015-06-16 14:27 ` [PATCH v3 02/35] asus-wmi: " Hans de Goede
2015-06-16 14:27 ` [PATCH v3 03/35] samsung-laptop: " Hans de Goede
2015-06-16 14:27 ` [PATCH v3 04/35] apple-gmux: Stop using acpi_video_dmi_demote_vendor() Hans de Goede
2015-06-16 14:27 ` [PATCH v3 05/35] acpi-video-detect: Remove the unused acpi_video_dmi_demote_vendor() function Hans de Goede
2015-06-16 14:27 ` [PATCH v3 06/35] acpi-video-detect: Make acpi_video_get_capabilities a private function Hans de Goede
2015-06-16 14:27 ` [PATCH v3 07/35] acpi-video-detect: Move acpi_is_video_device() to acpi/scan.c Hans de Goede
2015-06-16 14:27 ` [PATCH v3 08/35] acpi-video-detect: Move acpi_osi_is_win8 to osl.c Hans de Goede
2015-06-16 14:27 ` [PATCH v3 09/35] acpi-video-detect: video: Make video_detect code part of the video module Hans de Goede
2015-06-16 14:27 ` [PATCH v3 10/35] acpi-video-detect: Rewrite backlight interface selection logic Hans de Goede
2015-06-16 14:27 ` Hans de Goede [this message]
2015-06-16 14:27 ` [PATCH v3 12/35] drm: i915: Port to new backlight interface selection API Hans de Goede
2015-06-16 14:27 ` [PATCH v3 13/35] acpi-video: " Hans de Goede
2015-06-16 14:27 ` [PATCH v3 14/35] acpi-video: Move backlight notifier to video_detect.c Hans de Goede
2015-06-16 14:27 ` [PATCH v3 15/35] acpi-video: Move dmi_check_system from module_init to acpi_video_register Hans de Goede
2015-06-16 14:27 ` [PATCH v3 16/35] acpi-video: Fix acpi_video _register vs _unregister_backlight race Hans de Goede
2015-06-16 14:27 ` [PATCH v3 17/35] acer-wmi: Port to new backlight interface selection API Hans de Goede
2015-06-16 14:27 ` [PATCH v3 18/35] apple-gmux: " Hans de Goede
2015-06-16 14:27 ` [PATCH v3 19/35] asus-laptop: " Hans de Goede
2015-06-16 14:27 ` [PATCH v3 20/35] asus-wmi: " Hans de Goede
2015-06-16 14:27 ` [PATCH v3 21/35] compal-laptop: " Hans de Goede
2015-06-16 14:28 ` [PATCH v3 22/35] dell-laptop: " Hans de Goede
2015-06-16 14:28 ` [PATCH v3 23/35] dell-wmi: " Hans de Goede
2015-06-16 14:28 ` [PATCH v3 24/35] eeepc-laptop: " Hans de Goede
2015-06-16 14:28 ` [PATCH v3 25/35] fujitsu-laptop: " Hans de Goede
2015-06-16 14:28 ` [PATCH v3 26/35] ideapad-laptop: " Hans de Goede
2015-06-16 14:28 ` [PATCH v3 27/35] intel-oaktrail: " Hans de Goede
2015-06-16 14:28 ` [PATCH v3 28/35] msi-laptop: " Hans de Goede
2015-06-18 5:59 ` joeyli
2015-06-16 14:28 ` [PATCH v3 29/35] msi-wmi: " Hans de Goede
2015-06-16 14:28 ` [PATCH v3 30/35] samsung-laptop: " Hans de Goede
[not found] ` <1434464893-3529-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-16 14:28 ` [PATCH v3 31/35] sony-laptop: " Hans de Goede
2015-06-16 14:28 ` [PATCH v3 32/35] thinkpad-acpi: " Hans de Goede
2015-06-16 14:28 ` [PATCH v3 33/35] toshiba-acpi: " Hans de Goede
2015-06-16 14:28 ` [PATCH v3 34/35] acpi-video-detect: Remove old API Hans de Goede
2015-06-16 14:28 ` [PATCH v3 35/35] acpi-video: Make acpi_video_unregister_backlight() private Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434464893-3529-12-git-send-email-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=aaron.lu@intel.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=anisse@astier.eu \
--cc=bskeggs@redhat.com \
--cc=cezary.jackiewicz@gmail.com \
--cc=coproscefalo@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=dvhart@infradead.org \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=ike.pan@canonical.com \
--cc=jlee@suse.com \
--cc=jwoithe@just42.net \
--cc=linux-acpi@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=pali.rohar@gmail.com \
--cc=peter@piie.net \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox