From: Lukasz Anaczkowski <lukasz.anaczkowski@intel.com>
To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, jason@lakedaemon.net
Cc: rjw@rjwysocki.net, len.brown@intel.com, pavel@ucw.cz,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH] x86, acpi: Handle xapic/x2apic entries in MADT
Date: Tue, 14 Jul 2015 10:06:48 +0200 [thread overview]
Message-ID: <1436861209-4047-1-git-send-email-lukasz.anaczkowski@intel.com> (raw)
In-Reply-To: <55A3D7A3.90609@linaro.org>
On 07/13/2015 23:22 PM, Hanjun Guo wrote:
>> In case when BIOS is populating MADT wiht both x2apic and local apic
>> entries (as per ACPI spec), kernel builds it's processor table
>> in the following order: BSP, X2APIC, local APIC, resulting in
>> processors on the same core are not separated by core count.
>
> I'm confused here, I can't figure out where is the problem, could you
> explain it in detail?
>
> For me, logical CPU IDs allocated by OS will have mappings to physical
> CPU IDs, what you are saying seems CPU topology problem to me.
Sorry for confusion, I'll send another patch with updated commit message
where I'll try to put some more details and explanation. Hope that one will
be less confusing.
>> arch/x86/kernel/acpi/boot.c | 29 +++++++++++++-----
>> drivers/acpi/numa.c | 28 ++++++++++++-----
>> drivers/acpi/tables.c | 75 ++++++++++++++++++++++++++++-----------------
>> drivers/irqchip/irq-gic.c | 15 ++++++---
>
> Anyway, You also miss the SMP boot for ARM64 in ACPI way, which will
> cause compile error on ARM64.
The only symbol that's changed is acpi_parse_entries and I don't see
any calls to it in ARM64. I also tried compilation of arm64/defconfig
and it compiles fine. Could yoy point me to place where it might failing?
Thanks,
Lukasz
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
next prev parent reply other threads:[~2015-07-14 8:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 13:54 [PATCH] x86, acpi: Handle xapic/x2apic entries in MADT Lukasz Anaczkowski
2015-07-13 15:22 ` Hanjun Guo
2015-07-14 8:06 ` Lukasz Anaczkowski [this message]
2015-07-14 8:06 ` Lukasz Anaczkowski
2015-07-14 8:26 ` Jiang Liu
2015-07-14 11:17 ` Anaczkowski, Lukasz
2015-07-21 8:27 ` Thomas Gleixner
2015-07-14 14:24 ` Hanjun Guo
[not found] <alpine.DEB.2.11.1507211017590.18576 () nanos>
2015-07-30 17:43 ` Lukasz Anaczkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436861209-4047-1-git-send-email-lukasz.anaczkowski@intel.com \
--to=lukasz.anaczkowski@intel.com \
--cc=hpa@zytor.com \
--cc=jason@lakedaemon.net \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).