* [PATCH] acpi-video: Fix brightness keys for Thinkpad X240
@ 2015-07-22 5:52 Mathieu OTHACEHE
2015-07-23 1:40 ` Lu, Aaron
0 siblings, 1 reply; 2+ messages in thread
From: Mathieu OTHACEHE @ 2015-07-22 5:52 UTC (permalink / raw)
To: rjw, lenb; +Cc: linux-acpi, linux-kernel, Mathieu OTHACEHE
Thinkpad X240 laptop has a working acpi_video backlight control but
using the default native backlight control, brightness keys does not work.
This patch force acpi_video use for this laptop by adding an exception in
video_detect_dmi_table.
Signed-off-by: Mathieu OTHACEHE <m.othacehe@gmail.com>
---
drivers/acpi/video_detect.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 815f75e..c4bc5f2 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -173,6 +173,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X201s"),
},
},
+ {
+ .callback = video_detect_force_video,
+ .ident = "ThinkPad X240",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X240"),
+ },
+ },
/* The native backlight controls do not work on some older machines */
{
--
2.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] acpi-video: Fix brightness keys for Thinkpad X240
2015-07-22 5:52 [PATCH] acpi-video: Fix brightness keys for Thinkpad X240 Mathieu OTHACEHE
@ 2015-07-23 1:40 ` Lu, Aaron
0 siblings, 0 replies; 2+ messages in thread
From: Lu, Aaron @ 2015-07-23 1:40 UTC (permalink / raw)
To: m.othacehe@gmail.com, lenb@kernel.org, rjw@rjwysocki.net
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
On Wed, 2015-07-22 at 07:52 +0200, Mathieu OTHACEHE wrote:
> Thinkpad X240 laptop has a working acpi_video backlight control but
> using the default native backlight control, brightness keys does not
> work.
Is it because the events are not sent to user space?
Can you please file a bug in https://bugzilla.kernel.org/ under the
ACPI/Power-Video category and attach its acpidump/dmesg there? Thanks.
Regards,
Aaron
>
> This patch force acpi_video use for this laptop by adding an
> exception in
> video_detect_dmi_table.
>
> Signed-off-by: Mathieu OTHACEHE <m.othacehe@gmail.com>
> ---
> drivers/acpi/video_detect.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/acpi/video_detect.c
> b/drivers/acpi/video_detect.c
> index 815f75e..c4bc5f2 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -173,6 +173,14 @@ static const struct dmi_system_id
> video_detect_dmi_table[] = {
> DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X201s"),
> },
> },
> + {
> + .callback = video_detect_force_video,
> + .ident = "ThinkPad X240",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X240"),
> + },
> + },
>
> /* The native backlight controls do not work on some older
> machines */
> {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-23 1:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-22 5:52 [PATCH] acpi-video: Fix brightness keys for Thinkpad X240 Mathieu OTHACEHE
2015-07-23 1:40 ` Lu, Aaron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox