linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeremy Linton <jeremy.linton-5wv7dgnIgG8@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org,
	linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org,
	suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org,
	rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	Catalin.Marinas-5wv7dgnIgG8@public.gmane.org,
	Jeremy Linton <jeremy.linton-5wv7dgnIgG8@public.gmane.org>
Subject: [PATCH 2/3] Display a DMA error message
Date: Wed, 12 Aug 2015 16:51:29 -0500	[thread overview]
Message-ID: <1439416290-21228-3-git-send-email-jeremy.linton@arm.com> (raw)
In-Reply-To: <1439416290-21228-1-git-send-email-jeremy.linton-5wv7dgnIgG8@public.gmane.org>

If the ehci driver fails to configure the dma settings then display
a dev error instead of simply failing. This is triggered in an
ACPI world if the user fails to set the _CCA on the device.

Signed-off-by: Jeremy Linton <jeremy.linton-5wv7dgnIgG8@public.gmane.org>
---
 drivers/usb/host/ehci-platform.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
index 2593def..82e396f 100644
--- a/drivers/usb/host/ehci-platform.c
+++ b/drivers/usb/host/ehci-platform.c
@@ -162,8 +162,10 @@ static int ehci_platform_probe(struct platform_device *dev)
 
 	err = dma_coerce_mask_and_coherent(&dev->dev,
 		pdata->dma_mask_64 ? DMA_BIT_MASK(64) : DMA_BIT_MASK(32));
-	if (err)
+	if (err) {
+		dev_err(&dev->dev, "Error: DMA setup failed\n");
 		return err;
+	}
 
 	irq = platform_get_irq(dev, 0);
 	if (irq < 0) {
-- 
2.4.3


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-08-12 21:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-12 21:51 [PATCH 0/3] Enable EHCI-platform driver for use with ACPI Jeremy Linton
2015-08-12 21:51 ` [PATCH 1/3] Honor ACPI _CCA attribute setting Jeremy Linton
2015-08-14  1:45   ` Suravee Suthikulpanit
     [not found]     ` <55CD4832.7070301-5C7GfCeVMHo@public.gmane.org>
2015-08-14 13:14       ` Catalin Marinas
2015-08-14 14:12       ` Jeremy Linton
     [not found]         ` <55CDF74C.3050703-5wv7dgnIgG8@public.gmane.org>
2015-08-18  3:36           ` Huang Shijie
     [not found] ` <1439416290-21228-1-git-send-email-jeremy.linton-5wv7dgnIgG8@public.gmane.org>
2015-08-12 21:51   ` Jeremy Linton [this message]
2015-08-13 11:02     ` [PATCH 2/3] Display a DMA error message Hanjun Guo
     [not found]     ` <1439416290-21228-3-git-send-email-jeremy.linton-5wv7dgnIgG8@public.gmane.org>
2015-08-13 14:52       ` Alan Stern
2015-08-14 21:19     ` Arnd Bergmann
2015-08-14 21:44       ` Jeremy Linton
2015-08-14 21:56         ` Arnd Bergmann
2015-08-12 21:51   ` [PATCH 3/3] Add ACPI bindings for the EHCI platform driver Jeremy Linton
2015-08-13 11:50     ` Hanjun Guo
2015-08-13 14:45       ` Jeremy Linton
     [not found]     ` <1439416290-21228-4-git-send-email-jeremy.linton-5wv7dgnIgG8@public.gmane.org>
2015-08-13 14:53       ` Alan Stern
     [not found]         ` <Pine.LNX.4.44L0.1508131049001.1277-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2015-08-13 15:13           ` Jeremy Linton
     [not found]             ` <55CCB428.1000404-5wv7dgnIgG8@public.gmane.org>
2015-08-18  3:35               ` Huang Shijie
2015-08-13  9:44   ` [PATCH 0/3] Enable EHCI-platform driver for use with ACPI Graeme Gregory

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439416290-21228-3-git-send-email-jeremy.linton@arm.com \
    --to=jeremy.linton-5wv7dgnigg8@public.gmane.org \
    --cc=Catalin.Marinas-5wv7dgnIgG8@public.gmane.org \
    --cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
    --cc=suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).