From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v1 1/1] ACPI / osl: remove unused code Date: Mon, 17 Aug 2015 17:16:34 +0300 Message-ID: <1439820994.29746.281.camel@linux.intel.com> References: <1439566765-60490-1-git-send-email-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com ([192.55.52.93]:64890 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751308AbbHQOQh (ORCPT ); Mon, 17 Aug 2015 10:16:37 -0400 In-Reply-To: <1439566765-60490-1-git-send-email-andriy.shevchenko@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" , linux-acpi@vger.kernel.org On Fri, 2015-08-14 at 18:39 +0300, Andy Shevchenko wrote: > The readq() and writeq() helpers are available in the > asm-generic/io-64-nonatomic-hi-lo.h and asm-generic/io-64-nonatomic > -lo-hi.h > headers. Someone may use them when it's needed. Please discard this, it has been tested with CONFIG_ACPI=n only. I will resend this when test both cases. > > Signed-off-by: Andy Shevchenko > --- > drivers/acpi/osl.c | 28 ---------------------------- > 1 file changed, 28 deletions(-) > > diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c > index 21c1e71..11c32ff 100644 > --- a/drivers/acpi/osl.c > +++ b/drivers/acpi/osl.c > @@ -944,21 +944,6 @@ acpi_status acpi_os_write_port(acpi_io_address > port, u32 value, u32 width) > > EXPORT_SYMBOL(acpi_os_write_port); > > -#ifdef readq > -static inline u64 read64(const volatile void __iomem *addr) > -{ > - return readq(addr); > -} > -#else > -static inline u64 read64(const volatile void __iomem *addr) > -{ > - u64 l, h; > - l = readl(addr); > - h = readl(addr+4); > - return l | (h << 32); > -} > -#endif > - > acpi_status > acpi_os_read_memory(acpi_physical_address phys_addr, u64 *value, u32 > width) > { > @@ -1005,19 +990,6 @@ acpi_os_read_memory(acpi_physical_address > phys_addr, u64 *value, u32 width) > return AE_OK; > } > > -#ifdef writeq > -static inline void write64(u64 val, volatile void __iomem *addr) > -{ > - writeq(val, addr); > -} > -#else > -static inline void write64(u64 val, volatile void __iomem *addr) > -{ > - writel(val, addr); > - writel(val>>32, addr+4); > -} > -#endif > - > acpi_status > acpi_os_write_memory(acpi_physical_address phys_addr, u64 value, u32 > width) > { -- Andy Shevchenko Intel Finland Oy