From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"Luis R. Rodriguez" <mcgrof@suse.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Andrew Morton <akpm@linux-foundation.org>,
Borislav Petkov <bp@suse.de>, Christoph Hellwig <hch@lst.de>,
Christoph Jaeger <cj@linux.com>,
Dan Streetman <ddstreet@ieee.org>, Ingo Molnar <mingo@redhat.com>,
Juergen Gross <jgross@suse.com>, Len Brown <lenb@kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Thierry Reding <treding@nvidia.com>,
Thomas Gleixner <tglx@linutronix.de>,
Toshi Kani <toshi.kani@hp.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Will Deacon <will.deacon@arm.com>,
Linux ACPI <linux-acpi@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
X86 ML <x86@kernel.org>
Subject: Re: [PATCH v2] nd_blk: add support for "read flush" DSM flag
Date: Thu, 20 Aug 2015 15:15:39 -0600 [thread overview]
Message-ID: <1440105339.30197.11.camel@linux.intel.com> (raw)
In-Reply-To: <CAPcyv4iZb4ot2nEn5DJ+19wF-ZiWk=fKb41mehd6Pv0buGRxJQ@mail.gmail.com>
On Thu, 2015-08-20 at 13:27 -0700, Dan Williams wrote:
[...]
> With regards to the fencing, since we already take care to flush
> writes we don't need to fence at all for the flush, right? All we
> care about is that reads see valid data.
We were careful to flush writes, but we could still have (now stale) data in
the cache either due to a previous read or because of prefetching. So we
need to flush, and we need to fence to make sure that our flushing stays
correctly ordered with respect to our reads.
So, to recap, I think are options are:
a)
loop through aperture segments, flushing each without any fencing
mb() to order all the flushes
loop through aperture segments, doing the reads
b)
loop through aperture segments
flushing segment with mb() fencing
read the new data for this segment from the DIMM
Option b) is what is already implemented and is cleaner, but option a) has the
benefit of having many fewer fences.
next prev parent reply other threads:[~2015-08-20 21:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 22:48 [PATCH v2] nd_blk: add support for "read flush" DSM flag Ross Zwisler
2015-08-19 23:06 ` Dan Williams
2015-08-20 16:44 ` Ross Zwisler
2015-08-20 17:59 ` Dan Williams
2015-08-20 18:17 ` Ross Zwisler
2015-08-20 18:26 ` Dan Williams
2015-08-20 19:00 ` Ross Zwisler
2015-08-20 20:27 ` Dan Williams
2015-08-20 21:15 ` Ross Zwisler [this message]
2015-08-23 1:59 ` Dan Williams
2015-08-20 10:21 ` Will Deacon
2015-08-20 16:08 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440105339.30197.11.camel@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=cj@linux.com \
--cc=dan.j.williams@intel.com \
--cc=ddstreet@ieee.org \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mcgrof@suse.com \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=rusty@rustcorp.com.au \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hp.com \
--cc=treding@nvidia.com \
--cc=vishal.l.verma@intel.com \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).