From: Toshi Kani <toshi.kani@hp.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
Rafael J Wysocki <rafael.j.wysocki@intel.com>,
Robert Moore <robert.moore@intel.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Elliott, Robert (Server Storage)" <elliott@hp.com>
Subject: Re: [PATCH 2/2]: acpica/nfit: Rename not-armed bit definition
Date: Wed, 26 Aug 2015 17:29:56 -0600 [thread overview]
Message-ID: <1440631796.14237.67.camel@hp.com> (raw)
In-Reply-To: <CAJZ5v0g2AF7P=T-L_DJqLbOSAoqWcgZseTbeMCx9yChkNgFJOw@mail.gmail.com>
On Thu, 2015-08-27 at 01:16 +0200, Rafael J. Wysocki wrote:
> On Wed, Aug 26, 2015 at 11:12 PM, Toshi Kani <toshi.kani@hp.com> wrote:
> > On Wed, 2015-08-26 at 10:16 -0700, Dan Williams wrote:
> > > On Wed, Aug 26, 2015 at 9:20 AM, Toshi Kani <toshi.kani@hp.com> wrote:
> > > > ACPI 6.0 NFIT Memory Device State Flags in Table 5-129 defines
> > > > bit 3 as follows.
> > > >
> > > > Bit [3] set to 1 to indicate that the Memory Device is observed
> > > > to be not armed prior to OSPM hand off. A Memory Device is
> > > > considered armed if it is able to accept persistent writes.
> > > >
> > > > This bit is currently defined as ACPI_NFIT_MEM_ARMED, which can be
> > > > confusing as if the Memory Device is armed when this bit is set.
> > > >
> > > > Change the name to ACPI_NFIT_MEM_NOT_ARMED per the spec.
> > > >
> > > > Signed-off-by: Toshi Kani <toshi.kani@hp.com>
> > > > Cc: Dan Williams <dan.j.williams@intel.com>
> > > > Cc: Bob Moore <robert.moore@intel.com>
> > > > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > > > ---
> > > > drivers/acpi/nfit.c | 6 +++---
> > > > drivers/acpi/nfit.h | 2 +-
> > > > include/acpi/actbl1.h | 2 +-
> > >
> > > This file "include/acpi/actbl1.h" is owned by the ACPICA project so
> > > any changes need to come through them. But that said, I'm not sure we
> > > need friendly names at this level.
> >
> > I think the name is misleading, but I agree with the process and this
> > patch2 can be dropped. It'd be nice if the ACPICA project can pick it
> > up later when they have a chance, though.
>
> A good way to cause that to happen would be to send a patch to the
> ACPICA development list + maintainers as per MAINTAINERS.
Oh, I see. I did run get_maintainer.pl for this patch, but devel@acpica.org
did not come out in output... So, I did not realize this email list.
Thanks for the suggestion!
-Toshi
next prev parent reply other threads:[~2015-08-26 23:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 16:20 [PATCH 0/2]: acpi, nfit: Clarify memory device state flags Toshi Kani
2015-08-26 16:20 ` [PATCH 1/2]: nfit: Clarify memory device state flags strings Toshi Kani
2015-08-27 3:07 ` Ross Zwisler
2015-08-27 14:18 ` Toshi Kani
2015-08-27 18:57 ` Dan Williams
2015-08-27 19:02 ` Toshi Kani
2015-08-26 16:20 ` [PATCH 2/2]: acpica/nfit: Rename not-armed bit definition Toshi Kani
2015-08-26 17:16 ` Dan Williams
2015-08-26 19:59 ` Linda Knippers
2015-08-26 21:12 ` Toshi Kani
2015-08-26 21:30 ` Dan Williams
2015-08-26 21:44 ` Toshi Kani
2015-08-26 22:00 ` Dan Williams
2015-08-27 14:43 ` Linda Knippers
2015-08-27 15:30 ` Dan Williams
2015-08-27 15:35 ` Linda Knippers
2015-08-27 15:54 ` Dan Williams
2015-08-27 16:32 ` Linda Knippers
2015-08-27 17:04 ` Dan Williams
2015-08-27 17:09 ` Linda Knippers
2015-08-26 23:16 ` Rafael J. Wysocki
2015-08-26 23:29 ` Toshi Kani [this message]
2015-08-26 23:35 ` Toshi Kani
2015-08-27 1:56 ` Moore, Robert
2015-08-27 14:32 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440631796.14237.67.camel@hp.com \
--to=toshi.kani@hp.com \
--cc=dan.j.williams@intel.com \
--cc=elliott@hp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).