linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-acpi@vger.kernel.org, linux-i2c@vger.kernel.org,
	linux-gpio@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
	Wolfram Sang <wsa@the-dreams.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Mika Westerberg <mika.westerberg@intel.com>,
	"Puustinen, Ismo" <ismo.puustinen@intel.com>,
	"Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>,
	linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 4/8] mfd: intel_quark_i2c_gpio: support devices behind i2c bus
Date: Tue, 22 Sep 2015 13:10:15 +0300	[thread overview]
Message-ID: <1442916619-140607-5-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1442916619-140607-1-git-send-email-andriy.shevchenko@linux.intel.com>

On Intel Galileo Gen2 the GPIO expanders are connected to the i2c bus. For
those devices the ACPI table has specific parameters that refer to an actual
i2c host controller. Since MFD now copes with that specific configuration we
have to provide a necessary information how to distinguish devices in ACPI
namespace. Here the _ADR values are provided.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/mfd/intel_quark_i2c_gpio.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/mfd/intel_quark_i2c_gpio.c b/drivers/mfd/intel_quark_i2c_gpio.c
index 89bd4bf..e9fd33b 100644
--- a/drivers/mfd/intel_quark_i2c_gpio.c
+++ b/drivers/mfd/intel_quark_i2c_gpio.c
@@ -31,6 +31,10 @@
 #define MFD_I2C_BAR		0
 #define MFD_GPIO_BAR		1
 
+/* ACPI _ADR value to match the child node */
+#define MFD_ACPI_MATCH_GPIO	0ULL
+#define MFD_ACPI_MATCH_I2C	1ULL
+
 /* The base GPIO number under GPIOLIB framework */
 #define INTEL_QUARK_MFD_GPIO_BASE	8
 
@@ -82,9 +86,14 @@ static struct resource intel_quark_i2c_res[] = {
 	},
 };
 
+static struct mfd_cell_acpi_match intel_quark_acpi_match_i2c = {
+	.adr = MFD_ACPI_MATCH_I2C,
+};
+
 static struct mfd_cell intel_quark_mfd_i2c_cell = {
 	.id = MFD_I2C_BAR,
 	.name = "i2c_designware",
+	.acpi_match = &intel_quark_acpi_match_i2c,
 	.num_resources = ARRAY_SIZE(intel_quark_i2c_res),
 	.resources = intel_quark_i2c_res,
 	.ignore_resource_conflicts = true,
@@ -96,9 +105,14 @@ static struct resource intel_quark_gpio_res[] = {
 	},
 };
 
+static struct mfd_cell_acpi_match intel_quark_acpi_match_gpio = {
+	.adr = MFD_ACPI_MATCH_GPIO,
+};
+
 static struct mfd_cell intel_quark_mfd_gpio_cell = {
 	.id = MFD_GPIO_BAR,
 	.name = "gpio-dwapb",
+	.acpi_match = &intel_quark_acpi_match_gpio,
 	.num_resources = ARRAY_SIZE(intel_quark_gpio_res),
 	.resources = intel_quark_gpio_res,
 	.ignore_resource_conflicts = true,
-- 
2.5.1

  parent reply	other threads:[~2015-09-22 10:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-22 10:10 [PATCH v1 0/8] enable I2C devices behind I2C bus on Gen2 Andy Shevchenko
2015-09-22 10:10 ` [PATCH v1 1/8] i2c / ACPI: Rework I2C device scanning Andy Shevchenko
2015-09-22 10:10 ` [PATCH v1 2/8] mfd: core: redo ACPI matching of the children devices Andy Shevchenko
2015-09-22 22:15   ` Lee Jones
2015-09-23 11:06     ` Andy Shevchenko
2015-09-22 10:10 ` [PATCH v1 3/8] mfd: intel_quark_i2c_gpio: load gpio driver first Andy Shevchenko
2015-09-22 22:23   ` Lee Jones
2015-09-23  7:53     ` Andy Shevchenko
2015-09-24 17:29   ` Lee Jones
2015-09-22 10:10 ` Andy Shevchenko [this message]
2015-09-22 22:25   ` [PATCH v1 4/8] mfd: intel_quark_i2c_gpio: support devices behind i2c bus Lee Jones
2015-09-22 10:10 ` [PATCH v1 5/8] gpio: pca953x: store driver_data for future use Andy Shevchenko
2015-10-02 10:53   ` Linus Walleij
2015-10-02 12:16     ` Andy Shevchenko
2015-09-22 10:10 ` [PATCH v1 6/8] gpio: pca953x: support ACPI devices found on Galileo Gen2 Andy Shevchenko
2015-10-02 10:54   ` Linus Walleij
2015-09-22 10:10 ` [PATCH v1 7/8] at24: enable ACPI device " Andy Shevchenko
2015-09-22 10:10 ` [PATCH v1 8/8] pwm-pca9685: " Andy Shevchenko
2015-09-22 14:37   ` Thierry Reding
2015-09-23  8:41     ` Andy Shevchenko
2015-09-23 12:48       ` Thierry Reding
2015-09-23 12:56         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442916619-140607-5-git-send-email-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=ismo.puustinen@intel.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@intel.com \
    --cc=rjw@rjwysocki.net \
    --cc=srinivas.pandruvada@intel.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).