From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-acpi@vger.kernel.org, linux-i2c@vger.kernel.org,
Lee Jones <lee.jones@linaro.org>,
Wolfram Sang <wsa@the-dreams.de>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Mika Westerberg <mika.westerberg@intel.com>,
"Puustinen, Ismo" <ismo.puustinen@intel.com>,
"Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>,
linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v3 5/6] at24: enable ACPI device found on Galileo Gen2
Date: Wed, 7 Oct 2015 13:18:48 +0300 [thread overview]
Message-ID: <1444213129-29793-6-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1444213129-29793-1-git-send-email-andriy.shevchenko@linux.intel.com>
There is a 24c08 chip connected to i2c bus on Intel Galileo Gen2 board. Enable
it via ACPI ID INT3499.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/misc/eeprom/at24.c | 22 +++++++++++++++++++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index c6cb7f8..ed009a3 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -21,6 +21,7 @@
#include <linux/bitops.h>
#include <linux/jiffies.h>
#include <linux/of.h>
+#include <linux/acpi.h>
#include <linux/i2c.h>
#include <linux/platform_data/at24.h>
@@ -131,6 +132,12 @@ static const struct i2c_device_id at24_ids[] = {
};
MODULE_DEVICE_TABLE(i2c, at24_ids);
+static const struct acpi_device_id at24_acpi_ids[] = {
+ { "INT3499", AT24_DEVICE_MAGIC(8192 / 8, 0) },
+ { }
+};
+MODULE_DEVICE_TABLE(acpi, at24_acpi_ids);
+
/*-------------------------------------------------------------------------*/
/*
@@ -473,15 +480,23 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id)
struct at24_data *at24;
int err;
unsigned i, num_addresses;
- kernel_ulong_t magic;
+ kernel_ulong_t magic = 0;
if (client->dev.platform_data) {
chip = *(struct at24_platform_data *)client->dev.platform_data;
} else {
- if (!id->driver_data)
+ if (id) {
+ magic = id->driver_data;
+ } else {
+ const struct acpi_device_id *id;
+
+ id = acpi_match_device(at24_acpi_ids, &client->dev);
+ if (id)
+ magic = id->driver_data;
+ }
+ if (!magic)
return -ENODEV;
- magic = id->driver_data;
chip.byte_len = BIT(magic & AT24_BITMASK(AT24_SIZE_BYTELEN));
magic >>= AT24_SIZE_BYTELEN;
chip.flags = magic & AT24_BITMASK(AT24_SIZE_FLAGS);
@@ -661,6 +676,7 @@ static int at24_remove(struct i2c_client *client)
static struct i2c_driver at24_driver = {
.driver = {
.name = "at24",
+ .acpi_match_table = ACPI_PTR(at24_acpi_ids),
},
.probe = at24_probe,
.remove = at24_remove,
--
2.5.3
next prev parent reply other threads:[~2015-10-07 10:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 10:18 [PATCH v3 0/6] enable I2C devices behind I2C bus on Gen2 Andy Shevchenko
2015-10-07 10:18 ` [PATCH v3 1/6] i2c / ACPI: Rework I2C device scanning Andy Shevchenko
2015-10-20 14:26 ` Wolfram Sang
2015-10-07 10:18 ` [PATCH v3 2/6] mfd: core: redo ACPI matching of the children devices Andy Shevchenko
2015-10-30 18:54 ` Lee Jones
2015-10-07 10:18 ` [PATCH v3 3/6] mfd: intel_quark_i2c_gpio: load gpio driver first Andy Shevchenko
2015-10-07 10:18 ` [PATCH v3 4/6] mfd: intel_quark_i2c_gpio: support devices behind i2c bus Andy Shevchenko
2015-10-07 10:18 ` Andy Shevchenko [this message]
2015-10-20 14:28 ` [PATCH v3 5/6] at24: enable ACPI device found on Galileo Gen2 Wolfram Sang
2015-10-07 10:18 ` [PATCH v3 6/6] pwm-pca9685: " Andy Shevchenko
2015-10-15 10:21 ` Andy Shevchenko
2015-10-21 15:05 ` [PATCH v3 0/6] enable I2C devices behind I2C bus on Gen2 Andy Shevchenko
2015-10-30 18:54 ` Lee Jones
2015-10-30 19:05 ` Andy Shevchenko
2015-10-30 19:08 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444213129-29793-6-git-send-email-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ismo.puustinen@intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@intel.com \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).