From: Al Stone <al.stone@linaro.org>
To: linux-acpi@vger.kernel.org
Cc: linaro-acpi@lists.linaro.org, linaro-kernel@lists.linaro.org,
patches@linaro.org, Al Stone <al.stone@linaro.org>
Subject: [PATCH 4/4] ACPI: for bad_madt_entry(), the GIC ITS table is 20 bytes long, not 16
Date: Wed, 14 Oct 2015 15:26:25 -0600 [thread overview]
Message-ID: <1444857985-28844-5-git-send-email-al.stone@linaro.org> (raw)
In-Reply-To: <1444857985-28844-1-git-send-email-al.stone@linaro.org>
Correct a typo where bad_madt_entry() expected the MADT GIC ITS subtable
to be 16 bytes long, but it is actually 20 bytes. This is a cut'n'paste
error picked up from the spec and inadvertently replicated in code.
Signed-off-by: Al Stone <al.stone@linaro.org>
---
drivers/acpi/tables.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index 790d4b0..1b7c13e 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -292,7 +292,7 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header)
* GICD 0xc 24 24 24
* GICv2m MSI 0xd 24 24
* GICR 0xe 16 16
- * GIC ITS 0xf 16
+ * GIC ITS 0xf 20
*
* In the table, each length entry is what should be in the length
* field of the subtable, and -- in general -- it should match the
@@ -366,7 +366,7 @@ static struct acpi_madt_subtable_lengths spec_info[] = {
.madt_version = 3,
.num_types = 16,
.lengths = { 8, 12, 10, 8, 6, 12, 16, SUBTABLE_VARIABLE,
- 16, 16, 12, 80, 24, 24, 16, 16 }
+ 16, 16, 12, 80, 24, 24, 16, 20 }
},
{ /* terminator */
.major_version = 0,
--
2.4.3
next prev parent reply other threads:[~2015-10-14 21:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 21:26 [PATCH 0/4] Fix regressions uncovered by bad_madt_entry() patches Al Stone
2015-10-14 21:26 ` [PATCH 1/4] ACPI: workaround x86 firmware using reserved MADT subtable IDs Al Stone
2015-10-14 23:34 ` Rafael J. Wysocki
2015-10-14 21:26 ` [PATCH 2/4] ACPI: workaround x86 firmware with mis-matched FADT/MADT revisions Al Stone
2015-10-14 23:36 ` Rafael J. Wysocki
2015-10-14 21:26 ` [PATCH 3/4] ACPI: workaround FADT always being revision 2 Al Stone
2015-10-14 23:38 ` Rafael J. Wysocki
2015-10-14 21:26 ` Al Stone [this message]
2015-10-14 23:39 ` [PATCH 4/4] ACPI: for bad_madt_entry(), the GIC ITS table is 20 bytes long, not 16 Rafael J. Wysocki
2015-10-14 23:44 ` [PATCH 0/4] Fix regressions uncovered by bad_madt_entry() patches Rafael J. Wysocki
2015-10-15 0:23 ` Al Stone
2015-10-15 0:37 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444857985-28844-5-git-send-email-al.stone@linaro.org \
--to=al.stone@linaro.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox