From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toshi Kani Subject: Re: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM Date: Mon, 26 Oct 2015 10:51:08 -0600 Message-ID: <1445878268.20657.91.camel@hpe.com> References: <1445871783-18365-1-git-send-email-toshi.kani@hpe.com> <3908561D78D1C84285E8C5FCA982C28F32B5F5AF@ORSMSX114.amr.corp.intel.com> <1445877115.20657.88.camel@hpe.com> <3908561D78D1C84285E8C5FCA982C28F32B5F6D2@ORSMSX114.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from g1t6220.austin.hp.com ([15.73.96.84]:45585 "EHLO g1t6220.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751059AbbJZQzA (ORCPT ); Mon, 26 Oct 2015 12:55:00 -0400 In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F32B5F6D2@ORSMSX114.amr.corp.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Luck, Tony" , "bp@alien8.de" , "akpm@linux-foundation.org" , "Williams, Dan J" , "rjw@rjwysocki.net" Cc: "linux-mm@kvack.org" , "linux-nvdimm@lists.01.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" On Mon, 2015-10-26 at 16:46 +0000, Luck, Tony wrote: > > + ((param2 & PAGE_MASK) != PAGE_MASK)) > > return -EINVAL; > > > > The 3rd condition check makes sure that the param2 mask is the page size or less. So, > > I think we are OK on this. > > Oops. The original was even on the screen as part of the diff (which I signed off on > just two years ago). > > I'd be happier if you made it the 1st condition though, so we skip calling > region_intersects_*() with a nonsense "size" argument. Agreed. I will send an updated patch 3/3 later today, "[PATCH v2 UPDATE-2 3/3]". Thanks, -Toshi