Re: [PATCH v1 11/13] mfd: intel-lpss: Pass HSUART configuration via properties

Mika Westerberg
2015-11-25T12:16:03Z

On Tue, Nov 24, 2015 at 08:53:04PM +0100, Arnd Bergmann wrote:
> On Tuesday 24 November 2015 12:22:57 Andy Shevchenko wrote:
> > +static struct property_entry uart_properties[] = {
> > + PROPERTY_ENTRY_U32("reg-io-width", 4),
> > + PROPERTY_ENTRY_U32("reg-shift", 2),
> > + PROPERTY_ENTRY_U8("snps,uart-16550-compatible", 1),
> > + { },
> >
>
> If I read the binding correctly, the "snps,uart-16550-compatible" property
> is meant to be boolean, meaning true if present and zero-length or false
> if absent. Using a u8 propert instead feels wrong.
>
> Maybe we can have a PROPERTY_ENTRY_BOOL() for that?

That's a good idea. We'll add it to the next revision of the series.