* [PATCH 0/2] ACPI 6.1 update for NFIT Control Region Structure @ 2016-02-19 23:08 Toshi Kani 2016-02-19 23:08 ` [PATCH 1/2] ACPI/NFIT: Update Control Region Structure per ACPI 6.1 Toshi Kani 2016-02-19 23:08 ` [PATCH 2/2] nfit_test: Update SPD ID init handlings Toshi Kani 0 siblings, 2 replies; 6+ messages in thread From: Toshi Kani @ 2016-02-19 23:08 UTC (permalink / raw) To: rjw, dan.j.williams Cc: robert.moore, elliott, linux-nvdimm, linux-acpi, linux-kernel, devel ACPI 6.1, Table 5-133, updates NVDIMM Control Region Structure as follows. - Valid Fields, Manufacturing Location, and Manufacturing Date are added from reserved range. No change in the structure size. - IDs defined as SPD values are arrays of bytes. The spec clarified that they need to be represented as arrays of bytes as well. Patch 1 changes 'struct acpi_nfit_control_region' and the NFIT driver. Patch 2 changes the nfit test driver. link: http://www.uefi.org/sites/default/files/resources/ACPI_6_1.pdf --- Toshi Kani (2): 1/2 ACPI/NFIT: Update Control Region Structure per ACPI 6.1 2/2 nfit_test: Update SPD ID init handlings --- drivers/acpi/nfit.c | 75 ++++++++++++++++++++++++++++++++++------ include/acpi/actbl1.h | 24 ++++++++----- tools/testing/nvdimm/test/nfit.c | 64 ++++++++++++++++++++-------------- 3 files changed, 119 insertions(+), 44 deletions(-) ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] ACPI/NFIT: Update Control Region Structure per ACPI 6.1 2016-02-19 23:08 [PATCH 0/2] ACPI 6.1 update for NFIT Control Region Structure Toshi Kani @ 2016-02-19 23:08 ` Toshi Kani 2016-02-19 22:34 ` Dan Williams 2016-02-19 23:08 ` [PATCH 2/2] nfit_test: Update SPD ID init handlings Toshi Kani 1 sibling, 1 reply; 6+ messages in thread From: Toshi Kani @ 2016-02-19 23:08 UTC (permalink / raw) To: rjw, dan.j.williams Cc: robert.moore, elliott, linux-nvdimm, linux-acpi, linux-kernel, devel, Toshi Kani ACPI 6.1, Table 5-133, updates NVDIMM Control Region Structure as follows. - Valid Fields, Manufacturing Location, and Manufacturing Date are added from reserved range. No change in the structure size. - IDs defined as SPD values are arrays of bytes. The spec clarified that they need to be represented as arrays of bytes as well. This patch makes the following changes to support this update. - Change 'struct acpi_nfit_control_region' to reflect the update. SPD IDs are defined as arrays of bytes, so that they can be treated in the same way regardless of CPU endianness and are not miss-treated as little-endian numeric values. - Change the NFIT driver to show SPD ID values as array of bytes in sysfs. - Change the NFIT driver to show Manufacturing Location and Manufacturing Date when they are valid. - Change the NFIT driver to show an NVDIMM unique ID as defined in section 5.2.25.9 of the spec. - Change sprintf format to use "0x" instead of "#" since "%#02x" does not prepend '0' in some reason. link: http://www.uefi.org/sites/default/files/resources/ACPI_6_1.pdf Signed-off-by: Toshi Kani <toshi.kani@hpe.com> Cc: Rafael J. Wysocki <rjw@rjwysocki.net> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Robert Moore <robert.moore@intel.com> Cc: Robert Elliott <elliott@hpe.com> Cc: <devel@acpica.org> --- drivers/acpi/nfit.c | 75 ++++++++++++++++++++++++++++++++++++++++++------- include/acpi/actbl1.h | 24 ++++++++++------ 2 files changed, 80 insertions(+), 19 deletions(-) diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c index ad6d8c6..06677d9 100644 --- a/drivers/acpi/nfit.c +++ b/drivers/acpi/nfit.c @@ -722,7 +722,8 @@ static ssize_t vendor_show(struct device *dev, { struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); - return sprintf(buf, "%#x\n", dcr->vendor_id); + return sprintf(buf, "0x%02x%02x\n", + dcr->vendor_id[0], dcr->vendor_id[1]); } static DEVICE_ATTR_RO(vendor); @@ -731,7 +732,8 @@ static ssize_t rev_id_show(struct device *dev, { struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); - return sprintf(buf, "%#x\n", dcr->revision_id); + return sprintf(buf, "0x%02x%02x\n", + dcr->revision_id[0], dcr->revision_id[1]); } static DEVICE_ATTR_RO(rev_id); @@ -740,7 +742,8 @@ static ssize_t device_show(struct device *dev, { struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); - return sprintf(buf, "%#x\n", dcr->device_id); + return sprintf(buf, "0x%02x%02x\n", + dcr->device_id[0], dcr->device_id[1]); } static DEVICE_ATTR_RO(device); @@ -749,7 +752,7 @@ static ssize_t format_show(struct device *dev, { struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); - return sprintf(buf, "%#x\n", dcr->code); + return sprintf(buf, "0x%02x%02x\n", dcr->code[0], dcr->code[1]); } static DEVICE_ATTR_RO(format); @@ -758,7 +761,9 @@ static ssize_t serial_show(struct device *dev, { struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); - return sprintf(buf, "%#x\n", dcr->serial_number); + return sprintf(buf, "0x%02x%02x%02x%02x\n", + dcr->serial_number[0], dcr->serial_number[1], + dcr->serial_number[2], dcr->serial_number[3]); } static DEVICE_ATTR_RO(serial); @@ -776,6 +781,45 @@ static ssize_t flags_show(struct device *dev, } static DEVICE_ATTR_RO(flags); +static ssize_t mfg_location_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); + + return sprintf(buf, "0x%02x\n", dcr->manufacturing_location); +} +static DEVICE_ATTR_RO(mfg_location); + +static ssize_t mfg_date_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); + + return sprintf(buf, "0x%02x%02x\n", + dcr->manufacturing_date[0], dcr->manufacturing_date[1]); +} +static DEVICE_ATTR_RO(mfg_date); + +static ssize_t unique_id_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); + + if (dcr->valid_fields & ACPI_NFIT_CONTROL_MFG_INFO_VALID) + return sprintf(buf, "%02x%02x-%02x-%02x%02x-%02x%02x%02x%02x\n", + dcr->vendor_id[0], dcr->vendor_id[1], + dcr->manufacturing_location, + dcr->manufacturing_date[0], dcr->manufacturing_date[1], + dcr->serial_number[0], dcr->serial_number[1], + dcr->serial_number[2], dcr->serial_number[3]); + else + return sprintf(buf, "%02x%02x-%02x%02x%02x%02x\n", + dcr->vendor_id[0], dcr->vendor_id[1], + dcr->serial_number[0], dcr->serial_number[1], + dcr->serial_number[2], dcr->serial_number[3]); +} +static DEVICE_ATTR_RO(unique_id); + static struct attribute *acpi_nfit_dimm_attributes[] = { &dev_attr_handle.attr, &dev_attr_phys_id.attr, @@ -785,6 +829,9 @@ static struct attribute *acpi_nfit_dimm_attributes[] = { &dev_attr_serial.attr, &dev_attr_rev_id.attr, &dev_attr_flags.attr, + &dev_attr_mfg_location.attr, + &dev_attr_mfg_date.attr, + &dev_attr_unique_id.attr, NULL, }; @@ -792,11 +839,18 @@ static umode_t acpi_nfit_dimm_attr_visible(struct kobject *kobj, struct attribute *a, int n) { struct device *dev = container_of(kobj, struct device, kobj); + struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); - if (to_nfit_dcr(dev)) - return a->mode; - else + if (dcr) { + if (!(dcr->valid_fields & ACPI_NFIT_CONTROL_MFG_INFO_VALID) && + (a == &dev_attr_mfg_location.attr || + a == &dev_attr_mfg_date.attr)) + return 0; + else + return a->mode; + } else { return 0; + } } static struct attribute_group acpi_nfit_dimm_attribute_group = { @@ -956,7 +1010,7 @@ static const struct attribute_group *acpi_nfit_region_attribute_groups[] = { struct nfit_set_info { struct nfit_set_info_map { u64 region_offset; - u32 serial_number; + u8 serial_number[4]; u32 pad; } mapping[0]; }; @@ -1025,7 +1079,8 @@ static int acpi_nfit_init_interleave_set(struct acpi_nfit_desc *acpi_desc, } map->region_offset = memdev->region_offset; - map->serial_number = nfit_mem->dcr->serial_number; + memcpy(map->serial_number, nfit_mem->dcr->serial_number, + sizeof(map->serial_number)); } sort(&info->mapping[0], nr, sizeof(struct nfit_set_info_map), diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h index 16e0136..d8df62c 100644 --- a/include/acpi/actbl1.h +++ b/include/acpi/actbl1.h @@ -1040,15 +1040,18 @@ struct acpi_nfit_smbios { struct acpi_nfit_control_region { struct acpi_nfit_header header; u16 region_index; - u16 vendor_id; - u16 device_id; - u16 revision_id; - u16 subsystem_vendor_id; - u16 subsystem_device_id; - u16 subsystem_revision_id; - u8 reserved[6]; /* Reserved, must be zero */ - u32 serial_number; - u16 code; + u8 vendor_id[2]; + u8 device_id[2]; + u8 revision_id[2]; + u8 subsystem_vendor_id[2]; + u8 subsystem_device_id[2]; + u8 subsystem_revision_id[2]; + u8 valid_fields; + u8 manufacturing_location; + u8 manufacturing_date[2]; + u8 reserved[2]; /* Reserved, must be zero */ + u8 serial_number[4]; + u8 code[2]; u16 windows; u64 window_size; u64 command_offset; @@ -1059,6 +1062,9 @@ struct acpi_nfit_control_region { u8 reserved1[6]; /* Reserved, must be zero */ }; +/* Valid Fields */ +#define ACPI_NFIT_CONTROL_MFG_INFO_VALID (1) /* Manufacturing fields are valid */ + /* Flags */ #define ACPI_NFIT_CONTROL_BUFFERED (1) /* Block Data Windows implementation is buffered */ ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ACPI/NFIT: Update Control Region Structure per ACPI 6.1 2016-02-19 23:08 ` [PATCH 1/2] ACPI/NFIT: Update Control Region Structure per ACPI 6.1 Toshi Kani @ 2016-02-19 22:34 ` Dan Williams 2016-02-19 22:55 ` Moore, Robert 2016-02-19 23:44 ` Toshi Kani 0 siblings, 2 replies; 6+ messages in thread From: Dan Williams @ 2016-02-19 22:34 UTC (permalink / raw) To: Toshi Kani Cc: Rafael J. Wysocki, Robert Moore, Elliott, Robert (Persistent Memory), linux-nvdimm@lists.01.org, Linux ACPI, linux-kernel@vger.kernel.org, devel, Lv Zheng On Fri, Feb 19, 2016 at 3:08 PM, Toshi Kani <toshi.kani@hpe.com> wrote: > ACPI 6.1, Table 5-133, updates NVDIMM Control Region Structure > as follows. > - Valid Fields, Manufacturing Location, and Manufacturing Date > are added from reserved range. No change in the structure size. > - IDs defined as SPD values are arrays of bytes. The spec > clarified that they need to be represented as arrays of bytes > as well. > > This patch makes the following changes to support this update. > - Change 'struct acpi_nfit_control_region' to reflect the update. > SPD IDs are defined as arrays of bytes, so that they can be > treated in the same way regardless of CPU endianness and are > not miss-treated as little-endian numeric values. > - Change the NFIT driver to show SPD ID values as array of bytes > in sysfs. > - Change the NFIT driver to show Manufacturing Location and > Manufacturing Date when they are valid. > - Change the NFIT driver to show an NVDIMM unique ID as defined > in section 5.2.25.9 of the spec. > - Change sprintf format to use "0x" instead of "#" since "%#02x" > does not prepend '0' in some reason. > > link: http://www.uefi.org/sites/default/files/resources/ACPI_6_1.pdf > Signed-off-by: Toshi Kani <toshi.kani@hpe.com> > Cc: Rafael J. Wysocki <rjw@rjwysocki.net> > Cc: Dan Williams <dan.j.williams@intel.com> > Cc: Robert Moore <robert.moore@intel.com> > Cc: Robert Elliott <elliott@hpe.com> > Cc: <devel@acpica.org> > --- > drivers/acpi/nfit.c | 75 ++++++++++++++++++++++++++++++++++++++++++------- > include/acpi/actbl1.h | 24 ++++++++++------ > 2 files changed, 80 insertions(+), 19 deletions(-) Hi Toshi, I general looks good, but note that changes to include/acpi/actbl1.h need to go through the ACPICA project. Then their normal import process will bring it into the kernel. I added Lv to the cc. > > diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c > index ad6d8c6..06677d9 100644 > --- a/drivers/acpi/nfit.c > +++ b/drivers/acpi/nfit.c > @@ -722,7 +722,8 @@ static ssize_t vendor_show(struct device *dev, > { > struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > - return sprintf(buf, "%#x\n", dcr->vendor_id); > + return sprintf(buf, "0x%02x%02x\n", > + dcr->vendor_id[0], dcr->vendor_id[1]); > } > static DEVICE_ATTR_RO(vendor); > > @@ -731,7 +732,8 @@ static ssize_t rev_id_show(struct device *dev, > { > struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > - return sprintf(buf, "%#x\n", dcr->revision_id); > + return sprintf(buf, "0x%02x%02x\n", > + dcr->revision_id[0], dcr->revision_id[1]); > } > static DEVICE_ATTR_RO(rev_id); > > @@ -740,7 +742,8 @@ static ssize_t device_show(struct device *dev, > { > struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > - return sprintf(buf, "%#x\n", dcr->device_id); > + return sprintf(buf, "0x%02x%02x\n", > + dcr->device_id[0], dcr->device_id[1]); > } > static DEVICE_ATTR_RO(device); > > @@ -749,7 +752,7 @@ static ssize_t format_show(struct device *dev, > { > struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > - return sprintf(buf, "%#x\n", dcr->code); > + return sprintf(buf, "0x%02x%02x\n", dcr->code[0], dcr->code[1]); > } > static DEVICE_ATTR_RO(format); > > @@ -758,7 +761,9 @@ static ssize_t serial_show(struct device *dev, > { > struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > - return sprintf(buf, "%#x\n", dcr->serial_number); > + return sprintf(buf, "0x%02x%02x%02x%02x\n", > + dcr->serial_number[0], dcr->serial_number[1], > + dcr->serial_number[2], dcr->serial_number[3]); > } > static DEVICE_ATTR_RO(serial); These fixups look good. Can we split the new sysfs attributes below into their own patch? One more comments below: > > @@ -776,6 +781,45 @@ static ssize_t flags_show(struct device *dev, > } > static DEVICE_ATTR_RO(flags); > > +static ssize_t mfg_location_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > + > + return sprintf(buf, "0x%02x\n", dcr->manufacturing_location); > +} > +static DEVICE_ATTR_RO(mfg_location); > + > +static ssize_t mfg_date_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > + > + return sprintf(buf, "0x%02x%02x\n", > + dcr->manufacturing_date[0], dcr->manufacturing_date[1]); > +} > +static DEVICE_ATTR_RO(mfg_date); > + > +static ssize_t unique_id_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > + > + if (dcr->valid_fields & ACPI_NFIT_CONTROL_MFG_INFO_VALID) > + return sprintf(buf, "%02x%02x-%02x-%02x%02x-%02x%02x%02x%02x\n", > + dcr->vendor_id[0], dcr->vendor_id[1], > + dcr->manufacturing_location, > + dcr->manufacturing_date[0], dcr->manufacturing_date[1], > + dcr->serial_number[0], dcr->serial_number[1], > + dcr->serial_number[2], dcr->serial_number[3]); > + else > + return sprintf(buf, "%02x%02x-%02x%02x%02x%02x\n", > + dcr->vendor_id[0], dcr->vendor_id[1], > + dcr->serial_number[0], dcr->serial_number[1], > + dcr->serial_number[2], dcr->serial_number[3]); > +} > +static DEVICE_ATTR_RO(unique_id); Let's just call it 'id' as not to confuse it with a 'uuid'. Also if the manufacturing info is incorporated into the id then I don't think we need separate 'mfg_location' and 'mfg_date' attributes. If userspace really wants those separately it can just dump the NFIT table. ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 1/2] ACPI/NFIT: Update Control Region Structure per ACPI 6.1 2016-02-19 22:34 ` Dan Williams @ 2016-02-19 22:55 ` Moore, Robert 2016-02-19 23:44 ` Toshi Kani 1 sibling, 0 replies; 6+ messages in thread From: Moore, Robert @ 2016-02-19 22:55 UTC (permalink / raw) To: Williams, Dan J, Toshi Kani Cc: Rafael J. Wysocki, Elliott, Robert (Persistent Memory), linux-nvdimm@lists.01.org, Linux ACPI, linux-kernel@vger.kernel.org, devel@acpica.org, Zheng, Lv More importantly, the changes to actbl1.h need to be backported to the native ACPICA format. > -----Original Message----- > From: Dan Williams [mailto:dan.j.williams@intel.com] > Sent: Friday, February 19, 2016 2:35 PM > To: Toshi Kani > Cc: Rafael J. Wysocki; Moore, Robert; Elliott, Robert (Persistent Memory); > linux-nvdimm@lists.01.org; Linux ACPI; linux-kernel@vger.kernel.org; > devel@acpica.org; Zheng, Lv > Subject: Re: [PATCH 1/2] ACPI/NFIT: Update Control Region Structure per > ACPI 6.1 > > On Fri, Feb 19, 2016 at 3:08 PM, Toshi Kani <toshi.kani@hpe.com> wrote: > > ACPI 6.1, Table 5-133, updates NVDIMM Control Region Structure as > > follows. > > - Valid Fields, Manufacturing Location, and Manufacturing Date > > are added from reserved range. No change in the structure size. > > - IDs defined as SPD values are arrays of bytes. The spec > > clarified that they need to be represented as arrays of bytes > > as well. > > > > This patch makes the following changes to support this update. > > - Change 'struct acpi_nfit_control_region' to reflect the update. > > SPD IDs are defined as arrays of bytes, so that they can be > > treated in the same way regardless of CPU endianness and are > > not miss-treated as little-endian numeric values. > > - Change the NFIT driver to show SPD ID values as array of bytes > > in sysfs. > > - Change the NFIT driver to show Manufacturing Location and > > Manufacturing Date when they are valid. > > - Change the NFIT driver to show an NVDIMM unique ID as defined > > in section 5.2.25.9 of the spec. > > - Change sprintf format to use "0x" instead of "#" since "%#02x" > > does not prepend '0' in some reason. > > > > link: http://www.uefi.org/sites/default/files/resources/ACPI_6_1.pdf > > Signed-off-by: Toshi Kani <toshi.kani@hpe.com> > > Cc: Rafael J. Wysocki <rjw@rjwysocki.net> > > Cc: Dan Williams <dan.j.williams@intel.com> > > Cc: Robert Moore <robert.moore@intel.com> > > Cc: Robert Elliott <elliott@hpe.com> > > Cc: <devel@acpica.org> > > --- > > drivers/acpi/nfit.c | 75 > ++++++++++++++++++++++++++++++++++++++++++------- > > include/acpi/actbl1.h | 24 ++++++++++------ > > 2 files changed, 80 insertions(+), 19 deletions(-) > > Hi Toshi, > > I general looks good, but note that changes to include/acpi/actbl1.h need > to go through the ACPICA project. Then their normal import process will > bring it into the kernel. I added Lv to the cc. > > > > > diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c index > > ad6d8c6..06677d9 100644 > > --- a/drivers/acpi/nfit.c > > +++ b/drivers/acpi/nfit.c > > @@ -722,7 +722,8 @@ static ssize_t vendor_show(struct device *dev, { > > struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > > > - return sprintf(buf, "%#x\n", dcr->vendor_id); > > + return sprintf(buf, "0x%02x%02x\n", > > + dcr->vendor_id[0], dcr->vendor_id[1]); > > } > > static DEVICE_ATTR_RO(vendor); > > > > @@ -731,7 +732,8 @@ static ssize_t rev_id_show(struct device *dev, { > > struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > > > - return sprintf(buf, "%#x\n", dcr->revision_id); > > + return sprintf(buf, "0x%02x%02x\n", > > + dcr->revision_id[0], > > + dcr->revision_id[1]); > > } > > static DEVICE_ATTR_RO(rev_id); > > > > @@ -740,7 +742,8 @@ static ssize_t device_show(struct device *dev, { > > struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > > > - return sprintf(buf, "%#x\n", dcr->device_id); > > + return sprintf(buf, "0x%02x%02x\n", > > + dcr->device_id[0], dcr->device_id[1]); > > } > > static DEVICE_ATTR_RO(device); > > > > @@ -749,7 +752,7 @@ static ssize_t format_show(struct device *dev, { > > struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > > > - return sprintf(buf, "%#x\n", dcr->code); > > + return sprintf(buf, "0x%02x%02x\n", dcr->code[0], > > + dcr->code[1]); > > } > > static DEVICE_ATTR_RO(format); > > > > @@ -758,7 +761,9 @@ static ssize_t serial_show(struct device *dev, { > > struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > > > - return sprintf(buf, "%#x\n", dcr->serial_number); > > + return sprintf(buf, "0x%02x%02x%02x%02x\n", > > + dcr->serial_number[0], dcr->serial_number[1], > > + dcr->serial_number[2], dcr->serial_number[3]); > > } > > static DEVICE_ATTR_RO(serial); > > These fixups look good. > > Can we split the new sysfs attributes below into their own patch? One > more comments below: > > > > > @@ -776,6 +781,45 @@ static ssize_t flags_show(struct device *dev, } > > static DEVICE_ATTR_RO(flags); > > > > +static ssize_t mfg_location_show(struct device *dev, > > + struct device_attribute *attr, char *buf) { > > + struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > + > > + return sprintf(buf, "0x%02x\n", dcr->manufacturing_location); > > +} static DEVICE_ATTR_RO(mfg_location); > > + > > +static ssize_t mfg_date_show(struct device *dev, > > + struct device_attribute *attr, char *buf) { > > + struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > + > > + return sprintf(buf, "0x%02x%02x\n", > > + dcr->manufacturing_date[0], > > +dcr->manufacturing_date[1]); } static DEVICE_ATTR_RO(mfg_date); > > + > > +static ssize_t unique_id_show(struct device *dev, > > + struct device_attribute *attr, char *buf) { > > + struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > + > > + if (dcr->valid_fields & ACPI_NFIT_CONTROL_MFG_INFO_VALID) > > + return sprintf(buf, "%02x%02x-%02x-%02x%02x- > %02x%02x%02x%02x\n", > > + dcr->vendor_id[0], dcr->vendor_id[1], > > + dcr->manufacturing_location, > > + dcr->manufacturing_date[0], dcr- > >manufacturing_date[1], > > + dcr->serial_number[0], dcr->serial_number[1], > > + dcr->serial_number[2], dcr->serial_number[3]); > > + else > > + return sprintf(buf, "%02x%02x-%02x%02x%02x%02x\n", > > + dcr->vendor_id[0], dcr->vendor_id[1], > > + dcr->serial_number[0], dcr->serial_number[1], > > + dcr->serial_number[2], dcr->serial_number[3]); > > +} static DEVICE_ATTR_RO(unique_id); > > Let's just call it 'id' as not to confuse it with a 'uuid'. Also if the > manufacturing info is incorporated into the id then I don't think we need > separate 'mfg_location' and 'mfg_date' attributes. If userspace really > wants those separately it can just dump the NFIT table. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ACPI/NFIT: Update Control Region Structure per ACPI 6.1 2016-02-19 22:34 ` Dan Williams 2016-02-19 22:55 ` Moore, Robert @ 2016-02-19 23:44 ` Toshi Kani 1 sibling, 0 replies; 6+ messages in thread From: Toshi Kani @ 2016-02-19 23:44 UTC (permalink / raw) To: Dan Williams Cc: Rafael J. Wysocki, Robert Moore, Elliott, Robert (Persistent Memory), linux-nvdimm@lists.01.org, Linux ACPI, linux-kernel@vger.kernel.org, devel, Lv Zheng On Fri, 2016-02-19 at 14:34 -0800, Dan Williams wrote: > On Fri, Feb 19, 2016 at 3:08 PM, Toshi Kani <toshi.kani@hpe.com> wrote: > > ACPI 6.1, Table 5-133, updates NVDIMM Control Region Structure > > as follows. > > - Valid Fields, Manufacturing Location, and Manufacturing Date > > are added from reserved range. No change in the structure size. > > - IDs defined as SPD values are arrays of bytes. The spec > > clarified that they need to be represented as arrays of bytes > > as well. > > > > This patch makes the following changes to support this update. > > - Change 'struct acpi_nfit_control_region' to reflect the update. > > SPD IDs are defined as arrays of bytes, so that they can be > > treated in the same way regardless of CPU endianness and are > > not miss-treated as little-endian numeric values. > > - Change the NFIT driver to show SPD ID values as array of bytes > > in sysfs. > > - Change the NFIT driver to show Manufacturing Location and > > Manufacturing Date when they are valid. > > - Change the NFIT driver to show an NVDIMM unique ID as defined > > in section 5.2.25.9 of the spec. > > - Change sprintf format to use "0x" instead of "#" since "%#02x" > > does not prepend '0' in some reason. > > > > link: http://www.uefi.org/sites/default/files/resources/ACPI_6_1.pdf > > Signed-off-by: Toshi Kani <toshi.kani@hpe.com> > > Cc: Rafael J. Wysocki <rjw@rjwysocki.net> > > Cc: Dan Williams <dan.j.williams@intel.com> > > Cc: Robert Moore <robert.moore@intel.com> > > Cc: Robert Elliott <elliott@hpe.com> > > Cc: <devel@acpica.org> > > --- > > drivers/acpi/nfit.c | 75 > > ++++++++++++++++++++++++++++++++++++++++++------- > > include/acpi/actbl1.h | 24 ++++++++++------ > > 2 files changed, 80 insertions(+), 19 deletions(-) > > Hi Toshi, > > I general looks good, but note that changes to include/acpi/actbl1.h > need to go through the ACPICA project. Then their normal import > process will bring it into the kernel. I added Lv to the cc. Right. Thanks for adding Lv. > > > > diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c > > index ad6d8c6..06677d9 100644 > > --- a/drivers/acpi/nfit.c > > +++ b/drivers/acpi/nfit.c > > @@ -722,7 +722,8 @@ static ssize_t vendor_show(struct device *dev, > > { > > struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > > > - return sprintf(buf, "%#x\n", dcr->vendor_id); > > + return sprintf(buf, "0x%02x%02x\n", > > + dcr->vendor_id[0], dcr->vendor_id[1]); > > } > > static DEVICE_ATTR_RO(vendor); > > > > @@ -731,7 +732,8 @@ static ssize_t rev_id_show(struct device *dev, > > { > > struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > > > - return sprintf(buf, "%#x\n", dcr->revision_id); > > + return sprintf(buf, "0x%02x%02x\n", > > + dcr->revision_id[0], dcr- > > >revision_id[1]); > > } > > static DEVICE_ATTR_RO(rev_id); > > > > @@ -740,7 +742,8 @@ static ssize_t device_show(struct device *dev, > > { > > struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > > > - return sprintf(buf, "%#x\n", dcr->device_id); > > + return sprintf(buf, "0x%02x%02x\n", > > + dcr->device_id[0], dcr->device_id[1]); > > } > > static DEVICE_ATTR_RO(device); > > > > @@ -749,7 +752,7 @@ static ssize_t format_show(struct device *dev, > > { > > struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > > > - return sprintf(buf, "%#x\n", dcr->code); > > + return sprintf(buf, "0x%02x%02x\n", dcr->code[0], dcr- > > >code[1]); > > } > > static DEVICE_ATTR_RO(format); > > > > @@ -758,7 +761,9 @@ static ssize_t serial_show(struct device *dev, > > { > > struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > > > - return sprintf(buf, "%#x\n", dcr->serial_number); > > + return sprintf(buf, "0x%02x%02x%02x%02x\n", > > + dcr->serial_number[0], dcr->serial_number[1], > > + dcr->serial_number[2], dcr->serial_number[3]); > > } > > static DEVICE_ATTR_RO(serial); > > These fixups look good. > > Can we split the new sysfs attributes below into their own patch? Will do. > One more comments below: > > > > > @@ -776,6 +781,45 @@ static ssize_t flags_show(struct device *dev, > > } > > static DEVICE_ATTR_RO(flags); > > > > +static ssize_t mfg_location_show(struct device *dev, > > + struct device_attribute *attr, char *buf) > > +{ > > + struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > + > > + return sprintf(buf, "0x%02x\n", dcr->manufacturing_location); > > +} > > +static DEVICE_ATTR_RO(mfg_location); > > + > > +static ssize_t mfg_date_show(struct device *dev, > > + struct device_attribute *attr, char *buf) > > +{ > > + struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > + > > + return sprintf(buf, "0x%02x%02x\n", > > + dcr->manufacturing_date[0], dcr- > > >manufacturing_date[1]); > > +} > > +static DEVICE_ATTR_RO(mfg_date); > > + > > +static ssize_t unique_id_show(struct device *dev, > > + struct device_attribute *attr, char *buf) > > +{ > > + struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); > > + > > + if (dcr->valid_fields & ACPI_NFIT_CONTROL_MFG_INFO_VALID) > > + return sprintf(buf, "%02x%02x-%02x-%02x%02x- > > %02x%02x%02x%02x\n", > > + dcr->vendor_id[0], dcr->vendor_id[1], > > + dcr->manufacturing_location, > > + dcr->manufacturing_date[0], dcr- > > >manufacturing_date[1], > > + dcr->serial_number[0], dcr->serial_number[1], > > + dcr->serial_number[2], dcr->serial_number[3]); > > + else > > + return sprintf(buf, "%02x%02x-%02x%02x%02x%02x\n", > > + dcr->vendor_id[0], dcr->vendor_id[1], > > + dcr->serial_number[0], dcr->serial_number[1], > > + dcr->serial_number[2], dcr->serial_number[3]); > > +} > > +static DEVICE_ATTR_RO(unique_id); > > Let's just call it 'id' as not to confuse it with a 'uuid'. Also if > the manufacturing info is incorporated into the id then I don't think > we need separate 'mfg_location' and 'mfg_date' attributes. If > userspace really wants those separately it can just dump the NFIT > table. Make sense. I will remove 'mfg_location' and 'mfg_date', and rename 'unique_id' to 'id'. Thanks! -Toshi -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] nfit_test: Update SPD ID init handlings 2016-02-19 23:08 [PATCH 0/2] ACPI 6.1 update for NFIT Control Region Structure Toshi Kani 2016-02-19 23:08 ` [PATCH 1/2] ACPI/NFIT: Update Control Region Structure per ACPI 6.1 Toshi Kani @ 2016-02-19 23:08 ` Toshi Kani 1 sibling, 0 replies; 6+ messages in thread From: Toshi Kani @ 2016-02-19 23:08 UTC (permalink / raw) To: rjw, dan.j.williams Cc: robert.moore, elliott, linux-nvdimm, linux-acpi, linux-kernel, devel, Toshi Kani Update the test code that initializes SPD IDs of NFIT control region structures. nfit_set_spd_id() is added to handle initialization to an array of bytes. Signed-off-by: Toshi Kani <toshi.kani@hpe.com> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Rafael J. Wysocki <rjw@rjwysocki.net> --- tools/testing/nvdimm/test/nfit.c | 64 +++++++++++++++++++++++--------------- 1 file changed, 39 insertions(+), 25 deletions(-) diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c index 90bd2ea..283e187 100644 --- a/tools/testing/nvdimm/test/nfit.c +++ b/tools/testing/nvdimm/test/nfit.c @@ -160,6 +160,14 @@ static struct nfit_test *to_nfit_test(struct device *dev) return container_of(pdev, struct nfit_test, pdev); } +static void nfit_set_spd_id(u8 *dist, u64 value, size_t size) +{ + int shift; + + for (shift = size - 1; shift >= 0; shift--, dist++) + *dist = (u8)((value >> (8 * shift)) & 0xff); +} + static int nfit_test_cmd_get_config_size(struct nd_cmd_get_config_size *nd_cmd, unsigned int buf_len) { @@ -815,10 +823,11 @@ static void nfit_test0_setup(struct nfit_test *t) dcr->header.type = ACPI_NFIT_TYPE_CONTROL_REGION; dcr->header.length = sizeof(struct acpi_nfit_control_region); dcr->region_index = 0+1; - dcr->vendor_id = 0xabcd; - dcr->device_id = 0; - dcr->revision_id = 1; - dcr->serial_number = ~handle[0]; + nfit_set_spd_id(dcr->vendor_id, 0xabcd, sizeof(dcr->vendor_id)); + nfit_set_spd_id(dcr->device_id, 0, sizeof(dcr->device_id)); + nfit_set_spd_id(dcr->revision_id, 1, sizeof(dcr->revision_id)); + nfit_set_spd_id(dcr->serial_number, ~handle[0], + sizeof(dcr->serial_number)); dcr->windows = 1; dcr->window_size = DCR_SIZE; dcr->command_offset = 0; @@ -831,10 +840,11 @@ static void nfit_test0_setup(struct nfit_test *t) dcr->header.type = ACPI_NFIT_TYPE_CONTROL_REGION; dcr->header.length = sizeof(struct acpi_nfit_control_region); dcr->region_index = 1+1; - dcr->vendor_id = 0xabcd; - dcr->device_id = 0; - dcr->revision_id = 1; - dcr->serial_number = ~handle[1]; + nfit_set_spd_id(dcr->vendor_id, 0xabcd, sizeof(dcr->vendor_id)); + nfit_set_spd_id(dcr->device_id, 0, sizeof(dcr->device_id)); + nfit_set_spd_id(dcr->revision_id, 1, sizeof(dcr->revision_id)); + nfit_set_spd_id(dcr->serial_number, ~handle[1], + sizeof(dcr->serial_number)); dcr->windows = 1; dcr->window_size = DCR_SIZE; dcr->command_offset = 0; @@ -847,10 +857,11 @@ static void nfit_test0_setup(struct nfit_test *t) dcr->header.type = ACPI_NFIT_TYPE_CONTROL_REGION; dcr->header.length = sizeof(struct acpi_nfit_control_region); dcr->region_index = 2+1; - dcr->vendor_id = 0xabcd; - dcr->device_id = 0; - dcr->revision_id = 1; - dcr->serial_number = ~handle[2]; + nfit_set_spd_id(dcr->vendor_id, 0xabcd, sizeof(dcr->vendor_id)); + nfit_set_spd_id(dcr->device_id, 0, sizeof(dcr->device_id)); + nfit_set_spd_id(dcr->revision_id, 1, sizeof(dcr->revision_id)); + nfit_set_spd_id(dcr->serial_number, ~handle[2], + sizeof(dcr->serial_number)); dcr->windows = 1; dcr->window_size = DCR_SIZE; dcr->command_offset = 0; @@ -863,10 +874,11 @@ static void nfit_test0_setup(struct nfit_test *t) dcr->header.type = ACPI_NFIT_TYPE_CONTROL_REGION; dcr->header.length = sizeof(struct acpi_nfit_control_region); dcr->region_index = 3+1; - dcr->vendor_id = 0xabcd; - dcr->device_id = 0; - dcr->revision_id = 1; - dcr->serial_number = ~handle[3]; + nfit_set_spd_id(dcr->vendor_id, 0xabcd, sizeof(dcr->vendor_id)); + nfit_set_spd_id(dcr->device_id, 0, sizeof(dcr->device_id)); + nfit_set_spd_id(dcr->revision_id, 1, sizeof(dcr->revision_id)); + nfit_set_spd_id(dcr->serial_number, ~handle[3], + sizeof(dcr->serial_number)); dcr->windows = 1; dcr->window_size = DCR_SIZE; dcr->command_offset = 0; @@ -959,10 +971,11 @@ static void nfit_test0_setup(struct nfit_test *t) dcr->header.type = ACPI_NFIT_TYPE_CONTROL_REGION; dcr->header.length = sizeof(struct acpi_nfit_control_region); dcr->region_index = 4+1; - dcr->vendor_id = 0xabcd; - dcr->device_id = 0; - dcr->revision_id = 1; - dcr->serial_number = ~handle[4]; + nfit_set_spd_id(dcr->vendor_id, 0xabcd, sizeof(dcr->vendor_id)); + nfit_set_spd_id(dcr->device_id, 0, sizeof(dcr->device_id)); + nfit_set_spd_id(dcr->revision_id, 1, sizeof(dcr->revision_id)); + nfit_set_spd_id(dcr->serial_number, ~handle[4], + sizeof(dcr->serial_number)); dcr->windows = 1; dcr->window_size = DCR_SIZE; dcr->command_offset = 0; @@ -1128,11 +1141,12 @@ static void nfit_test1_setup(struct nfit_test *t) dcr->header.type = ACPI_NFIT_TYPE_CONTROL_REGION; dcr->header.length = sizeof(struct acpi_nfit_control_region); dcr->region_index = 0+1; - dcr->vendor_id = 0xabcd; - dcr->device_id = 0; - dcr->revision_id = 1; - dcr->serial_number = ~0; - dcr->code = 0x201; + nfit_set_spd_id(dcr->vendor_id, 0xabcd, sizeof(dcr->vendor_id)); + nfit_set_spd_id(dcr->device_id, 0, sizeof(dcr->device_id)); + nfit_set_spd_id(dcr->revision_id, 1, sizeof(dcr->revision_id)); + nfit_set_spd_id(dcr->serial_number, ~0, + sizeof(dcr->serial_number)); + nfit_set_spd_id(dcr->code, 0x201, sizeof(dcr->code)); dcr->windows = 0; dcr->window_size = 0; dcr->command_offset = 0; ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-19 23:08 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-02-19 23:08 [PATCH 0/2] ACPI 6.1 update for NFIT Control Region Structure Toshi Kani 2016-02-19 23:08 ` [PATCH 1/2] ACPI/NFIT: Update Control Region Structure per ACPI 6.1 Toshi Kani 2016-02-19 22:34 ` Dan Williams 2016-02-19 22:55 ` Moore, Robert 2016-02-19 23:44 ` Toshi Kani 2016-02-19 23:08 ` [PATCH 2/2] nfit_test: Update SPD ID init handlings Toshi Kani
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).