From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toshi Kani Subject: [PATCH v2 2/3] ACPI/NFIT: Add NVDIMM ID "id" under sysfs Date: Mon, 22 Feb 2016 14:55:29 -0700 Message-ID: <1456178130-26468-3-git-send-email-toshi.kani@hpe.com> References: <1456178130-26468-1-git-send-email-toshi.kani@hpe.com> Return-path: In-Reply-To: <1456178130-26468-1-git-send-email-toshi.kani@hpe.com> Sender: linux-kernel-owner@vger.kernel.org To: rjw@rjwysocki.net, dan.j.williams@intel.com Cc: robert.moore@intel.com, lv.zheng@intel.com, elliott@hpe.com, linux-nvdimm@lists.01.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, devel@acpica.org, Toshi Kani List-Id: linux-acpi@vger.kernel.org ACPI 6.1, section 5.2.25.9, defines an identifier for an NVDIMM. Change the NFIT driver to create read-only "id" file under NVDIMM's nfit directory of sysfs, which shows the NVDIMM ID. Signed-off-by: Toshi Kani Cc: Rafael J. Wysocki Cc: Dan Williams Cc: Robert Elliott --- drivers/acpi/nfit.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c index 4982a18..677cf89 100644 --- a/drivers/acpi/nfit.c +++ b/drivers/acpi/nfit.c @@ -781,6 +781,26 @@ static ssize_t flags_show(struct device *dev, } static DEVICE_ATTR_RO(flags); +static ssize_t id_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct acpi_nfit_control_region *dcr = to_nfit_dcr(dev); + + if (dcr->valid_fields & ACPI_NFIT_CONTROL_MFG_INFO_VALID) + return sprintf(buf, "%02x%02x-%02x-%02x%02x-%02x%02x%02x%02x\n", + dcr->vendor_id[0], dcr->vendor_id[1], + dcr->manufacturing_location, + dcr->manufacturing_date[0], dcr->manufacturing_date[1], + dcr->serial_number[0], dcr->serial_number[1], + dcr->serial_number[2], dcr->serial_number[3]); + else + return sprintf(buf, "%02x%02x-%02x%02x%02x%02x\n", + dcr->vendor_id[0], dcr->vendor_id[1], + dcr->serial_number[0], dcr->serial_number[1], + dcr->serial_number[2], dcr->serial_number[3]); +} +static DEVICE_ATTR_RO(id); + static struct attribute *acpi_nfit_dimm_attributes[] = { &dev_attr_handle.attr, &dev_attr_phys_id.attr, @@ -790,6 +810,7 @@ static struct attribute *acpi_nfit_dimm_attributes[] = { &dev_attr_serial.attr, &dev_attr_rev_id.attr, &dev_attr_flags.attr, + &dev_attr_id.attr, NULL, };