From: Vishal Verma <vishal@stellar.sh>
To: "Zhang, Haozhong" <haozhong.zhang@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Xiao Guangrong <guangrong.xiao@linux.intel.com>
Cc: linux-acpi@vger.kernel.org, linux-nvdimm@lists.01.org, "Williams,
Dan J" <dan.j.williams@intel.com>
Subject: Re: [PATCH v2] nfit: Continue init even if ARS commands are unimplemented
Date: Thu, 03 Mar 2016 21:27:49 -0700 [thread overview]
Message-ID: <1457065669.17916.1.camel@stellar.sh> (raw)
In-Reply-To: <20160304033451.GA6267@hz-desktop.sh.intel.com>
On Fri, 2016-03-04 at 11:34 +0800, Zhang, Haozhong wrote:
> On 03/04/16 11:28, Xiao Guangrong wrote:
> >
> >
> > CCed: Haozhong.
> >
> > On 03/04/2016 06:39 AM, Vishal Verma wrote:
> > >
> > > If firmware doesn't implement any of the ARS commands, take that
> > > to
> > > mean that ARS is unsupported, and continue to initialize regions
> > > without
> > > bad block lists. We cannot make the assumption that ARS commands
> > > will be
> > > unconditionally supported on all NVDIMMs.
> > >
> > > Cc: Dan Williams <dan.j.williams@intel.com>
> > > Reported-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
> > Thank you for the fix, Vishal! it looks good to me.
> >
> > However, It is haozhong's credit as he is the one reported the bug
> > not
> > me. :)
> >
> Thanks! I have tested on QEMU which has not implemented ARS yet and
> this patch does work.
>
> Tested-by: Haozhong Zhang <haozhong.zhang@intel.com>
Thanks, both Haozhong and Guangrong. Dan, can you please fixup the
Reported-by tag when you apply.
-Vishal
> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@lists.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-03-04 4:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 22:39 [PATCH v2] nfit: Continue init even if ARS commands are unimplemented Vishal Verma
2016-03-03 22:53 ` Dan Williams
2016-03-04 3:28 ` Xiao Guangrong
2016-03-04 3:34 ` Zhang, Haozhong
2016-03-04 4:27 ` Vishal Verma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457065669.17916.1.camel@stellar.sh \
--to=vishal@stellar.sh \
--cc=dan.j.williams@intel.com \
--cc=guangrong.xiao@linux.intel.com \
--cc=haozhong.zhang@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).