From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] ACPICA: Remove unnecessary "\n" from an ACPI_INFO boot message Date: Wed, 30 Mar 2016 21:27:07 -0700 Message-ID: <1459398427.1744.2.camel@perches.com> References: <74bc15316c48bb33c0954d94c0595720ee0955bd.1459187689.git.bristot@redhat.com> <94F2FBAB4432B54E8AACC7DFDE6C92E37E455538@ORSMSX110.amr.corp.intel.com> <56FC7941.2080202@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from smtprelay0077.hostedemail.com ([216.40.44.77]:40524 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751225AbcCaE1O (ORCPT ); Thu, 31 Mar 2016 00:27:14 -0400 In-Reply-To: <56FC7941.2080202@redhat.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Daniel Bristot de Oliveira , "Moore, Robert" , "Zheng, Lv" , "Wysocki, Rafael J" , Len Brown Cc: "linux-acpi@vger.kernel.org" , "devel@acpica.org" , "linux-kernel@vger.kernel.org" On Wed, 2016-03-30 at 22:11 -0300, Daniel Bristot de Oliveira wrote: > On 03/29/2016 04:09 PM, Moore, Robert wrote: > > Actually, I did in fact put that there to break up the output after the tables are loaded. Is this a problem? > Well, I do not believe that there is a real problem on it. > > On the other hand, it does not seem to be common to have blank lines in > the kernel log, and as there is no info about from where the black line > comes from, it does not even seems to be connected to the previous > message. So although my patch is about "cosmetics", IMHO it is worth as > pattern or best practices. FWIW: I agree with Daniel.