Re: [PATCH] Add Intel Poulsbo Stub Driver

Randy Dunlap
2010-09-10T15:03:48Z

On 09/09/10 21:36, Joey Lee wrote:
>>> + # Poulsbo stub depends on ACPI_VIDEO when ACPI is enabled
>>> + # but for select to work, need to select ACPI_VIDEO's dependencies, ick
>>> + select ACPI_VIDEO if ACPI
>>
>> What does it do when ACPI is not enabled? Does the driver even build
>> when APCI is not enabled? (given the acpi_video* calls in it)
>>
>
> This driver will not do anything if API is not enabled. It only call
> acpi_video_register/acpi_video_unregister, and acpi/video.h handle it
> like the following:
>
> #if (defined CONFIG_ACPI_VIDEO || defined CONFIG_ACPI_VIDEO_MODULE)
> extern int acpi_video_register(void);
> extern void acpi_video_unregister(void);
> extern int acpi_video_get_edid(struct acpi_device *device, int type,
> int device_id, void **edid);
> #else
> static inline int acpi_video_register(void) { return 0; }
> static inline void acpi_video_unregister(void) { return; }
> static inline int acpi_video_get_edid(struct acpi_device *device, int
> type,
> int device_id, void **edid)
> {
> return -ENODEV;
> }
> #endif
>
> So, I think don't need add "depends on ACPI_VIDEO". How do you think?

Yes, OK, I see. Thanks.

--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***