Re: [PATCH V6 0/8] vfio, platform: add ACPI support

Auger Eric
2016-06-07T20:38:06Z

Hi Sinan,
Le 29/05/2016 à 00:01, Sinan Kaya a écrit :
> The device tree code checks for the presence of a reset driver and calls
> the of_reset function pointer by looking up the reset driver as a module.
>
> ACPI defines _RST method to perform device level reset. After the _RST
> method is executed, the OS can resume using the device.
>
> This patch checks the presence of _RST method and calls the _RST
> method when reset is requested.
>
> Changes from V5:
> 1. Handle reset function call failures in open and release (new patch).
> 2. Bring out extra debug information when failure happens (new patch).
> 3. Address review comments from Eric in ACPI _RST patch.

I think you need a respin to fix the deallocation issue in 7/8 + 1st patch missing.
Afterwards I don't have any other comments at that point. I will test the
dt non-regression tomorrow.

Thanks

Eric

> Sinan Kaya (8):
> vfio: platform: move reset call to a common function
> vfio: platform: determine reset capability
> vfio: platform: add support for ACPI probe
> vfio: platform: add extra debug info argument to call reset
> vfio: platform: call _RST method when using ACPI
> vfio, platform: make reset driver a requirement by default
> vfio: platform: check reset call return code during open
> vfio: platform: check reset call return code during release
>
> drivers/vfio/platform/vfio_amba.c | 5 +
> drivers/vfio/platform/vfio_platform.c | 5 +
> drivers/vfio/platform/vfio_platform_common.c | 169 ++++++++++++++++++++++----
> drivers/vfio/platform/vfio_platform_private.h | 2 +
> 4 files changed, 159 insertions(+), 22 deletions(-)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html