Re: [PATCH V6 6/8] vfio, platform: make reset driver a requirement by default

Sinan Kaya
2016-06-13T02:32:37Z

On 6/7/2016 3:59 PM, Auger Eric wrote:
>> - vfio_platform_get_reset(vdev);
>> > + ret = vfio_platform_get_reset(vdev);
>> > + if (ret && vdev->reset_required) {
>> > + pr_err("vfio: no reset function found for device %s\n",
>> > + vdev->name);
>> > + iommu_group_put(group);
>> > + return ret;
> nit: in case you respin you can factorize the group put and return ret in a goto label
> (since also used above).
>
> Besides Reviewed-by: Eric Auger <eric.auger@redhat.com>

thanks, done. I'll respin with your request.

--
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project