Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays

Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays

[Joe Perches]

(adding acpi folks)

On Sat, 2016-06-04 at 01:14 -0400, George Spelvin wrote:
> Both input and output code is simplified if we use a mapping from binary
> UUID index to ASCII UUID position.  This lets us combine hyphen-skipping
> and endian-swapping into one table.
> 
> This significantly simplifies __uuid_to_bin(), which was using *two*
> lookup tables.

Seems sensible, thanks.

Trivially, acpi defines this but doesn't seem to use it.

include/acpi/acconfig.h:#define UUID_STRING_LENGTH          36  /* Total length of a UUID string */

And Ingo commented last month:
https://lkml.org/lkml/2016/4/29/69

Maybe this __uuid_to_bin function should be made public and
the acpi version in drivers/acpi/acpica/utuuid.c should be
removed.

Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays

[George Spelvin]

Joe Perches wrote:
> And Ingo commented last month:
> https://lkml.org/lkml/2016/4/29/69
>
> Maybe this __uuid_to_bin function should be made public and
> the acpi version in drivers/acpi/acpica/utuuid.c should be
> removed.

I agree with the second part, but not the first; the uuid_le_to_bin()
wrapper is better for the job, and already public.

Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays

[Andy Shevchenko]

On Sat, 2016-06-04 at 09:29 -0700, Joe Perches wrote:
> (adding acpi folks)


> 
> Trivially, acpi defines this but doesn't seem to use it.
> 
> include/acpi/acconfig.h:#define UUID_STRING_LENGTH          36  /*
> Total length of a UUID string */
> 
> And Ingo commented last month:
> https://lkml.org/lkml/2016/4/29/69
> 
> Maybe this __uuid_to_bin function should be made public and
> the acpi version in drivers/acpi/acpica/utuuid.c should be
> removed.

Looks like you missed my first version of (other) series.
http://www.spinics.net/lists/linux-api/msg17518.html


-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays

[Joe Perches]

On Sun, 2016-06-05 at 17:19 +0300, Andy Shevchenko wrote:
> On Sat, 2016-06-04 at 09:29 -0700, Joe Perches wrote:
> > (adding acpi folks)
> > Trivially, acpi defines this but doesn't seem to use it.
> > 
> > include/acpi/acconfig.h:#define UUID_STRING_LENGTH          36  /*
> > Total length of a UUID string */
> > 
> > And Ingo commented last month:
> > https://lkml.org/lkml/2016/4/29/69
> > 
> > Maybe this __uuid_to_bin function should be made public and
> > the acpi version in drivers/acpi/acpica/utuuid.c should be
> > removed.
> Looks like you missed my first version of (other) series.
> http://www.spinics.net/lists/linux-api/msg17518.html

More like if a patch isn't applied after several months,
it's likely not going to be applied unless it is resent.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays

[Andy Shevchenko]

On Sun, 2016-06-05 at 08:34 -0700, Joe Perches wrote:
> On Sun, 2016-06-05 at 17:19 +0300, Andy Shevchenko wrote:
> > On Sat, 2016-06-04 at 09:29 -0700, Joe Perches wrote:
> > > (adding acpi folks)
> > > Trivially, acpi defines this but doesn't seem to use it.
> > > 
> > > include/acpi/acconfig.h:#define UUID_STRING_LENGTH          36  /*
> > > Total length of a UUID string */
> > > 
> > > And Ingo commented last month:
> > > https://lkml.org/lkml/2016/4/29/69
> > > 
> > > Maybe this __uuid_to_bin function should be made public and
> > > the acpi version in drivers/acpi/acpica/utuuid.c should be
> > > removed.
> > Looks like you missed my first version of (other) series.
> > http://www.spinics.net/lists/linux-api/msg17518.html
> 
> More like if a patch isn't applied after several months,
> it's likely not going to be applied unless it is resent.

The discussion was about how to proceed with uuid_*_cmp() functions that
have prototypes like uuid_le x1, x2. Any ideas come to mind?

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html