linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v4 1/5] acpi: battery: Split battery driver for reuse by DPTF power participant
Date: Thu, 30 Jun 2016 15:39:05 -0700	[thread overview]
Message-ID: <1467326345.4497.0.camel@linux.intel.com> (raw)
In-Reply-To: <CAJZ5v0geNqtMi99JE4NTVByxUB-JECKPpVGRnO8=YKQMZCAoGA@mail.gmail.com>

On Fri, 2016-07-01 at 00:08 +0200, Rafael J. Wysocki wrote:
> On Thu, Jun 30, 2016 at 2:00 AM, Srinivas Pandruvada
> <srinivas.pandruvada@linux.intel.com> wrote:
> > DPTF power participant device have common objects with ACPI battery
> > device
> > "PNP0C0A". For example the main battery objects:
> > _BST: returns dynamic battery information
> > _BIX: The static battery properties and control method
> > Also both can register with power_supply class to present
> > properties
> > of a typical battery device.
> > 
> > To avoid code duplication, the existing battery driver is split
> > into two
> > parts:
> > - A common part
> > - ACPI battery driver
> > 
> > battery_common
> > Most of the existing battery driver source, except ACPI enumeration
> > part
> > moved a separate file. It exposes an interface, which can be used
> > by ACPI
> > battery driver and DPTF power participant driver.
> > Also the current battery driver code had lots of check_patch
> > errors.
> > These check_patch errors are addressed in this battery_common.
> > These are
> > the main interface functions:
> > acpi_battery_common_add
> > acpi_battery_common_remove
> > acpi_battery_common_resume
> > acpi_battery_common_notify
> > 
> > battery: This is ACPI battery driver, which just enumerate on
> > PNP0C0A
> > device and use interface functions offered by battery common part.
> > 
> > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel
> > .com>
> 
> Are there any functional changes in this patch?
No.

Thanks,
Srinivas

  reply	other threads:[~2016-06-30 22:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-30  0:00 [PATCH v4 0/5] DPTF Platform power participant driver Srinivas Pandruvada
2016-06-30  0:00 ` [PATCH v4 1/5] acpi: battery: Split battery driver for reuse by DPTF power participant Srinivas Pandruvada
2016-06-30 22:08   ` Rafael J. Wysocki
2016-06-30 22:39     ` Srinivas Pandruvada [this message]
2016-06-30  0:00 ` [PATCH v4 2/5] acpi: battery: make optional power_supply register Srinivas Pandruvada
2016-06-30 22:10   ` Rafael J. Wysocki
2016-06-30  0:00 ` [PATCH v4 3/5] acpi: battery: allow externel access of battery information Srinivas Pandruvada
2016-06-30  0:00 ` [PATCH v4 4/5] acpi: dptf_power: Add DPTF power participant Srinivas Pandruvada
2016-06-30 22:15   ` Rafael J. Wysocki
2016-06-30  0:00 ` [PATCH v4 5/5] acpi: battery_common: battery present status for INT3407 Srinivas Pandruvada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467326345.4497.0.camel@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).