linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Mayer <mmayer@broadcom.com>
To: Robert Moore <robert.moore@intel.com>,
	Lv Zheng <lv.zheng@intel.com>,
	Rafael Wysocki <rafael.j.wysocki@intel.com>,
	Len Brown <lenb@kernel.org>
Cc: Markus Mayer <mmayer@broadcom.com>,
	linux-acpi@vger.kernel.org, devel@acpica.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/6] ACPICA: make use of new strtolower() function
Date: Thu, 30 Jun 2016 16:50:09 -0700	[thread overview]
Message-ID: <1467330612-26242-4-git-send-email-mmayer@broadcom.com> (raw)
In-Reply-To: <1467330612-26242-1-git-send-email-mmayer@broadcom.com>

Call strtolower() rather than walking the string explicitly to convert
it to lowercase.

Signed-off-by: Markus Mayer <mmayer@broadcom.com>
---

*** Please note that there don't seem to be any callers of acpi_ut_strlwr().
*** It may be possible to remove the function altogether.

 drivers/acpi/acpica/utnonansi.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/drivers/acpi/acpica/utnonansi.c b/drivers/acpi/acpica/utnonansi.c
index 3465fe2..b6e11dc 100644
--- a/drivers/acpi/acpica/utnonansi.c
+++ b/drivers/acpi/acpica/utnonansi.c
@@ -64,19 +64,8 @@ ACPI_MODULE_NAME("utnonansi")
  ******************************************************************************/
 void acpi_ut_strlwr(char *src_string)
 {
-	char *string;
-
 	ACPI_FUNCTION_ENTRY();
-
-	if (!src_string) {
-		return;
-	}
-
-	/* Walk entire string, lowercasing the letters */
-
-	for (string = src_string; *string; string++) {
-		*string = (char)tolower((int)*string);
-	}
+	strtolower(src_string);
 }
 
 /*******************************************************************************
-- 
2.7.4

  parent reply	other threads:[~2016-06-30 23:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-30 23:50 [PATCH 0/6] lib: string: add function strtolower() Markus Mayer
2016-06-30 23:50 ` [PATCH 1/6] " Markus Mayer
2016-07-01 10:52   ` Jani Nikula
2016-07-01 17:14     ` Markus Mayer
2016-07-01 17:33       ` Jani Nikula
2016-07-01 21:08   ` Rasmus Villemoes
2016-07-04 20:18     ` Markus Mayer
2016-06-30 23:50 ` Markus Mayer [this message]
2016-07-01  1:11   ` [PATCH 3/6] ACPICA: make use of new strtolower() function Moore, Robert
     [not found]     ` <CAGt4E5uqbjaubPWE4rq-T7MvqAmwpUhvakM+jv+Sen8est9U5g@mail.gmail.com>
     [not found]       ` <94F2FBAB4432B54E8AACC7DFDE6C92E37E4C381C@ORSMSX110.amr.corp.intel.com>
2016-07-01  4:13         ` Markus Mayer
2016-07-01  4:32           ` Moore, Robert
2016-06-30 23:50 ` [PATCH 4/6] ACPI / device_sysfs: " Markus Mayer
2016-07-01 20:44   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467330612-26242-4-git-send-email-mmayer@broadcom.com \
    --to=mmayer@broadcom.com \
    --cc=devel@acpica.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lv.zheng@intel.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).