From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Mayer Subject: [PATCH v2 3/7] ACPI / device_sysfs: make use of new strtolower() function Date: Tue, 5 Jul 2016 13:47:07 -0700 Message-ID: <1467751631-22878-4-git-send-email-mmayer@broadcom.com> References: <1467751631-22878-1-git-send-email-mmayer@broadcom.com> Return-path: Received: from mail-qk0-f169.google.com ([209.85.220.169]:36166 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755423AbcGEUsb (ORCPT ); Tue, 5 Jul 2016 16:48:31 -0400 Received: by mail-qk0-f169.google.com with SMTP id u68so23030819qkc.3 for ; Tue, 05 Jul 2016 13:48:30 -0700 (PDT) In-Reply-To: <1467751631-22878-1-git-send-email-mmayer@broadcom.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Rafael Wysocki , Len Brown Cc: Markus Mayer , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Call strtolower() rather than walking the string explicitly to convert it to lowercase. Signed-off-by: Markus Mayer --- Rafael, I left off your ACK, since the implementation of my function changed somewhat (no check for NULL, return value is different). Please let me know if you are still okay with this. drivers/acpi/device_sysfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c index 7b2c48f..1db38c7 100644 --- a/drivers/acpi/device_sysfs.c +++ b/drivers/acpi/device_sysfs.c @@ -200,12 +200,10 @@ static int create_of_modalias(struct acpi_device *acpi_dev, char *modalias, const union acpi_object *of_compatible, *obj; int len, count; int i, nval; - char *c; acpi_get_name(acpi_dev->handle, ACPI_SINGLE_NAME, &buf); /* DT strings are all in lower case */ - for (c = buf.pointer; *c != '\0'; c++) - *c = tolower(*c); + strtolower(buf.pointer); len = snprintf(modalias, size, "of:N%sT", (char *)buf.pointer); ACPI_FREE(buf.pointer); -- 2.7.4