From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kani, Toshimitsu" Subject: Re: [PATCH v3] libnvdimm, pmem: use REQ_FUA, REQ_FLUSH for nvdimm_flush() Date: Wed, 13 Jul 2016 19:46:56 +0000 Message-ID: <1468439194.8908.55.camel@hpe.com> References: <146812112233.32932.5962348391051315694.stgit@dwillia2-desk3.amr.corp.intel.com> <146836238217.14676.14154640837011539657.stgit@dwillia2-desk3.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <146836238217.14676.14154640837011539657.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Content-Language: en-US Content-ID: <8D9730C05FEFEA4F845150793B721D1F-mmYPd6ayCNGroOM5E8FhRbjFIynDaujOfM0AETQt39g@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: "dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , "linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org" Cc: "linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "hch-jcswGhMUV9g@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-acpi@vger.kernel.org On Tue, 2016-07-12 at 15:26 -0700, Dan Williams wrote: > Given that nvdimm_flush() has higher overhead than wmb_pmem() (pointer > chasing through nd_region), and that we otherwise assume a platform has > ADR capability when flush hints are not present, move nvdimm_flush() to > REQ_FLUSH context. > > Note that we still arrange for nvdimm_flush() to be called even in the > ADR case. We need at least once wmb() fence to push buffered writes in > the cpu out to the ADR protected domain. > > Cc: Toshi Kani > Cc: Ross Zwisler > Signed-off-by: Dan Williams This looks good to me. Reviewed-by: Toshi Kani Thanks, -Toshi