public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	"Luck, Tony" <tony.luck@intel.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH 1/3] pmem: clarify a debug print in pmem_clear_poison
Date: Tue, 19 Jul 2016 17:15:25 +0000	[thread overview]
Message-ID: <1468948496.30121.60.camel@intel.com> (raw)
In-Reply-To: <CAPcyv4gpRGJLVfoC3o-rVypQtppkAKg1hObr=1EhcT3Y3g8KUw@mail.gmail.com>

On Tue, 2016-07-19 at 08:53 -0700, Dan Williams wrote:
> On Mon, Jul 18, 2016 at 5:44 PM, Vishal Verma <vishal.l.verma@intel.co
> m> wrote:
> > Prefix the sector number being cleared with a '0x' to make it clear
> > that
> > this is a hex value.
> > 
> > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> > ---
> >  drivers/nvdimm/pmem.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> > index 608fc44..29ab25b 100644
> > --- a/drivers/nvdimm/pmem.c
> > +++ b/drivers/nvdimm/pmem.c
> > @@ -57,7 +57,7 @@ static void pmem_clear_poison(struct pmem_device
> > *pmem, phys_addr_t offset,
> >         cleared = nvdimm_clear_poison(dev, pmem->phys_addr + offset,
> > len);
> > 
> >         if (cleared > 0 && cleared / 512) {
> > -               dev_dbg(dev, "%s: %llx clear %ld sector%s\n",
> > +               dev_dbg(dev, "%s: 0x%llx clear %ld sector%s\n",
> 
> %#llx is a bit smaller / more readable.  Shall I just fix this up on
> applying?

TIL :) Yes you can do the fixup, thanks!

  reply	other threads:[~2016-07-19 17:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-19  0:44 [PATCH 0/3] ARS rescanning triggered by latent errors or userspace Vishal Verma
2016-07-19  0:44 ` [PATCH 1/3] pmem: clarify a debug print in pmem_clear_poison Vishal Verma
     [not found]   ` <1468889100-30698-2-git-send-email-vishal.l.verma-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-07-19 15:53     ` Dan Williams
2016-07-19 17:15       ` Verma, Vishal L [this message]
2016-07-19 17:56         ` Vishal Verma
     [not found] ` <1468889100-30698-1-git-send-email-vishal.l.verma-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-07-19  0:44   ` [PATCH 2/3] nfit, libnvdimm: allow an ARS rescan to be triggered on demand Vishal Verma
     [not found]     ` <1468889100-30698-3-git-send-email-vishal.l.verma-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-07-19 16:15       ` Dan Williams
     [not found]         ` <CAPcyv4guVe2Mm_EaBMMRqpfCahR_E0xbhtE30VoDAb+sqvK=AQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-19 17:45           ` Vishal Verma
2016-07-19 18:00             ` Dan Williams
2016-07-19 18:32               ` Vishal Verma
2016-07-19  0:45   ` [PATCH 3/3] nfit: do an ARS rescan on hitting a latent media error Vishal Verma
     [not found]     ` <1468889100-30698-4-git-send-email-vishal.l.verma-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-07-19 16:24       ` Dan Williams
2016-07-19 17:55         ` Vishal Verma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468948496.30121.60.camel@intel.com \
    --to=vishal.l.verma@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox