Re: [PATCH v3 2/2] power: Adds support for Smart Battery System Manager

Peter Rosin
2016-07-25T10:44:49Z

On 2016-07-19 20:51, Karl-Heinz Schneider wrote:
> Hi Wolfram,
>
> Am Dienstag, den 19.07.2016, 06:17 +0200 schrieb Wolfram Sang:
>>> + data->muxc = i2c_mux_alloc(adapter, dev, SBSM_MAX_BATS, 0,
>>> + I2C_MUX_LOCKED, &sbsm_select, NULL);
>>> + if (!data->muxc) {
>>> + dev_err(dev, "failed to alloc i2c mux\n");
>>
>> Don't print errors on ENOMEM.
>
> Will be fixed on next revision.
>
>>
>> Other than that, looks good to me, yet Peter has more insight to
>> i2c-muxes these days.
>>
> Tanks for review.
>
> Will wait another few days before sending a new revision, hence changes
> are rather small.

Looks good to me from a muxing perspective, with very a minor nit that the
devicetree bindings do not point to i2c-mux.txt for where "standard i2c-mux
nodes" are described.

Cheers,
Peter