From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v3 0/3] Date: Tue, 09 Aug 2016 19:01:17 +0300 Message-ID: <1470758477.25395.12.camel@linux.intel.com> References: <1468580485-28567-1-git-send-email-wangkefeng.wang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: Received: from mga04.intel.com ([192.55.52.120]:42731 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752103AbcHIQB0 (ORCPT ); Tue, 9 Aug 2016 12:01:26 -0400 In-Reply-To: <1468580485-28567-1-git-send-email-wangkefeng.wang@huawei.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Kefeng Wang , gregkh@linuxfoundation.org, jslaby@suse.com, linux-serial@vger.kernel.org Cc: linux-acpi@vger.kernel.org, guohanjun@huawei.com, z.liuxinliang@hisilicon.com, xuwei5@hisilicon.com, graeme.gregory@linaro.org On Fri, 2016-07-15 at 19:01 +0800, Kefeng Wang wrote: > Make dw8250_set_termios() as the default set_termios callback for 8250 > dw uart, correct me > if I am wrong. > > Then add ACPI support for uart on Hisilicon Hip05 soc, be careful that > it is not 16500 > compatible. Meanwhile, set dw8250_serial_out32 to keep consistent > between serial_out > and serial_in in ACPI. I will review it perhaps late this week. Though have a quick question, did you test it? I hope you have done. > > Change since v2: > - Add a new patch to use new var dev in probe > - Use built-in device properties to set device parameters for existing > device probed by acpi, >   suggested by Andy Shevchenko  > > > Change since v1: > - Use acpi_match_device() instead of acpi_dev_found(), limit the check > to the device >   being probed and not a global search for whole DSDT (pointed by grae > me.gregory@linaro.org) > > Kefeng Wang (3): >   serial: 8250_dw: make dw8250_set_termios as default set_termios >     callback >   serial: 8250_dw: Use new dev variable in probe >   serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc > >  drivers/tty/serial/8250/8250_dw.c | 71 ++++++++++++++++++++++------ > ----------- >  1 file changed, 41 insertions(+), 30 deletions(-) > -- Andy Shevchenko Intel Finland Oy