From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rui Wang Subject: [PATCH v3 3/5] x86/ioapic: Fix setup_res() failing to get resource Date: Wed, 10 Aug 2016 12:01:56 +0800 Message-ID: <1470801718-29004-4-git-send-email-rui.y.wang@intel.com> References: <1470801718-29004-1-git-send-email-rui.y.wang@intel.com> Return-path: Received: from mga09.intel.com ([134.134.136.24]:30603 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751058AbcHJES1 (ORCPT ); Wed, 10 Aug 2016 00:18:27 -0400 In-Reply-To: <1470801718-29004-1-git-send-email-rui.y.wang@intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: helgaas@kernel.org, tglx@linutronix.de, rjw@rjwysocki.net Cc: tony.luck@intel.com, bhelgaas@google.com, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, rui.y.wang@intel.com acpi_dev_filter_resource_type() returns 0 on success, and 1 on failure. A return value of zero means there's a matching resource, so we should continue within setup_res() to get the resource. Signed-off-by: Rui Wang --- drivers/acpi/ioapic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/ioapic.c b/drivers/acpi/ioapic.c index 2449377..8ab6d42 100644 --- a/drivers/acpi/ioapic.c +++ b/drivers/acpi/ioapic.c @@ -46,7 +46,7 @@ static acpi_status setup_res(struct acpi_resource *acpi_res, void *data) struct resource_win win; res->flags = 0; - if (acpi_dev_filter_resource_type(acpi_res, IORESOURCE_MEM) == 0) + if (acpi_dev_filter_resource_type(acpi_res, IORESOURCE_MEM)) return AE_OK; if (!acpi_dev_resource_memory(acpi_res, res)) { -- 1.8.3.1