linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kani, Toshimitsu" <toshi.kani-ZPxbGqLxI0U@public.gmane.org>
To: "dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
	<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org"
	<linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org>
Cc: "linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
	<rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/3] acpi, nfit: add dimm device notification support
Date: Fri, 26 Aug 2016 18:26:19 +0000	[thread overview]
Message-ID: <1472235940.1532.23.camel@hpe.com> (raw)
In-Reply-To: <147198926249.3136.6163137762013359047.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

On Tue, 2016-08-23 at 14:54 -0700, Dan Williams wrote:
> Per "ACPI 6.1 Section 9.20.3" NVDIMM devices, children of the
> ACPI0012 NVDIMM Root device, can receive health event notifications.
> 
> Given that these devices are precluded from registering a
> notification handler via acpi_driver.acpi_device_ops (due to no
> _HID), we use acpi_install_notify_handler() directly.  

I've confirmed that this ACPI notify handler is called properly.

> The registered handler, acpi_nvdimm_notify(), triggers a poll(2)
> event on the nmemX/nfit/flags sysfs attribute when a health event
> notification is received.

This sounds good idea, but should we document that the value of sysfs
'flags' itself does not get updated?  User space program will then need
to call its _DSM to get health status.

Thanks,
-Toshi
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  parent reply	other threads:[~2016-08-26 18:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23 21:54 [PATCH 0/3] acpi, nfit: nvdimm notification support + tests Dan Williams
     [not found] ` <147198925154.3136.14739108342311837939.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-23 21:54   ` [PATCH 1/3] tools/testing/nvdimm: unit test for acpi_nfit_notify() Dan Williams
2016-08-23 21:54   ` [PATCH 2/3] acpi, nfit: add dimm device notification support Dan Williams
     [not found]     ` <147198926249.3136.6163137762013359047.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-26 18:26       ` Kani, Toshimitsu [this message]
     [not found]         ` <1472235940.1532.23.camel-ZPxbGqLxI0U@public.gmane.org>
2016-08-26 18:39           ` Dan Williams
     [not found]             ` <CAPcyv4hdLdGR7LLyHVZsyXK6dNL1+jF927Siqt_D2DfPSifwwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-29 22:19               ` Kani, Toshimitsu
2016-09-01 19:46       ` Dan Williams
2016-08-23 21:54   ` [PATCH 3/3] tools/testing/nvdimm: unit test for acpi_nvdimm_notify() Dan Williams
2016-08-23 22:39   ` [PATCH 0/3] acpi, nfit: nvdimm notification support + tests Vishal Verma
2016-08-29 21:50   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472235940.1532.23.camel@hpe.com \
    --to=toshi.kani-zpxbgqlxi0u@public.gmane.org \
    --cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
    --cc=rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).