Re: [PATCH V8 3/3] irqchip: qcom: Add IRQ combiner driver

Marc Zyngier
2016-12-13T18:43:40Z

On 13/12/16 18:21, Joe Perches wrote:
> On Tue, 2016-12-13 at 10:23 -0500, Agustin Vega-Frias wrote:
>> On 2016-12-07 13:16, Marc Zyngier wrote:
>>>> + }
>>>> +
>>>> + combiner->domain = irq_domain_create_linear(
>>>> + pdev->dev.fwnode, combiner->nirqs, &domain_ops, combiner);
>>>
>>> On a single line, please. Do no listen to the checkpatch police that
>>> will tell you otherwise. It really hurt my eyes to see this opening
>>> bracket and *nothing* after that.
>>
>> Will do.
>
> It seems generally preferred to have at least one argument on the
> same line as the function being called.
>
> So, here are some options:
>
> Maximally fill the lines to 80 columns with the value being set
> and function call while aligning to open parenthesis
>
> combiner->domain = irq_domain_create_linear(pdev->dev.fwnode,
> combiner->nirqs,
> &domain_ops, combiner);

I can live with something like this.

> Use a separate line for the function call:
>
> combiner->domain =
> irq_domain_create_linear(pdev->dev.fwnode, combiner->nirqs,
> &domain_ops, combiner);

But I find this one pretty horrid.

> Or just ignore the 80 column limit wherever you deem appropriate.

Which is my usual advise. I consider the 80 column rule a good way of
limiting the complexity of code (if the nesting pushes you too far on
the right of the screen, you're doing something wrong), but not for
simple statements such as this one.

Thanks,

M.
--
Jazz is not dead. It just smells funny...