linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-acpi@vger.kernel.org, devicetree@vger.kernel.org
Cc: sudeep.holla@arm.com, lorenzo.pieralisi@arm.com,
	mika.westerberg@linux.intel.com, rafael@kernel.org,
	mark.rutland@arm.com, broonie@kernel.org, robh@kernel.org,
	ahs3@redhat.com
Subject: [PATCH v2 12/16] device property: Obtain device's fwnode independently of FW type
Date: Thu,  2 Feb 2017 18:22:22 +0200	[thread overview]
Message-ID: <1486052546-19257-13-git-send-email-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <1486052546-19257-1-git-send-email-sakari.ailus@linux.intel.com>

OF uses struct device's of_node field (of type struct device_node) to
refer to the device's OF properties. ACPI employs the fwnode field
instead. The latter is of type fwnode_handle, which is also embedded in
struct device_node.

The struct fwnode_handle pointer in both cases can be used as an argument
for the device property API which is firmware agnostic. Also make
obtaining the firmware node independent of the type of the firmware.

On ACPI, rely on the endpoint node child index in determining the endpoint
ID. There's no need for a separate "endpoint" property as such: this is a
software concept and the value is deterministically derived from the ACPI
table.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/base/property.c  | 33 +++++++++++++++++++++++++++++++++
 include/linux/fwnode.h   |  6 ++++++
 include/linux/property.h | 13 +++++++++++++
 3 files changed, 52 insertions(+)

diff --git a/drivers/base/property.c b/drivers/base/property.c
index 760c6c5..3f77404 100644
--- a/drivers/base/property.c
+++ b/drivers/base/property.c
@@ -1245,3 +1245,36 @@ fwnode_graph_get_remote_endpoint(struct fwnode_handle *fwnode)
 	return endpoint;
 }
 EXPORT_SYMBOL_GPL(fwnode_graph_get_remote_endpoint);
+
+/*
+ * fwnode_graph_parse_endpoint() - parse common endpoint node properties
+ * @node: pointer to endpoint device_node
+ * @endpoint: pointer to the fwnode endpoint data structure
+ *
+ * The caller should hold a reference to @node.
+ */
+int fwnode_graph_parse_endpoint(struct fwnode_handle *fwnode,
+				struct fwnode_endpoint *endpoint)
+{
+	struct fwnode_handle *port_fwnode = fwnode_get_parent(fwnode);
+
+	memset(endpoint, 0, sizeof(*endpoint));
+
+	endpoint->local_fwnode = fwnode;
+	/*
+	 * It doesn't matter whether the two calls below succeed.
+	 * If they don't then the default value 0 is used.
+	 */
+	if (is_acpi_node(port_fwnode)) {
+		fwnode_property_read_u32(port_fwnode, "port", &endpoint->port);
+		fwnode_property_read_u32(fwnode, "endpoint", &endpoint->id);
+	} else {
+		fwnode_property_read_u32(port_fwnode, "reg", &endpoint->port);
+		fwnode_property_read_u32(fwnode, "reg", &endpoint->id);
+	}
+
+	fwnode_handle_put(port_fwnode);
+
+	return 0;
+}
+EXPORT_SYMBOL(fwnode_graph_parse_endpoint);
diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
index 8bd28ce..cb60f29 100644
--- a/include/linux/fwnode.h
+++ b/include/linux/fwnode.h
@@ -27,4 +27,10 @@ struct fwnode_handle {
 	struct fwnode_handle *secondary;
 };
 
+struct fwnode_endpoint {
+	unsigned int port;
+	unsigned int id;
+	const struct fwnode_handle *local_fwnode;
+};
+
 #endif
diff --git a/include/linux/property.h b/include/linux/property.h
index b4b1545..eb7ba73 100644
--- a/include/linux/property.h
+++ b/include/linux/property.h
@@ -13,7 +13,9 @@
 #ifndef _LINUX_PROPERTY_H_
 #define _LINUX_PROPERTY_H_
 
+#include <linux/device.h>
 #include <linux/fwnode.h>
+#include <linux/of.h>
 #include <linux/types.h>
 
 struct device;
@@ -273,4 +275,15 @@ struct fwnode_handle *fwnode_graph_get_remote_port(
 struct fwnode_handle *fwnode_graph_get_remote_endpoint(
 	struct fwnode_handle *fwnode);
 
+static inline struct fwnode_handle *device_fwnode_handle(struct device *dev)
+{
+	if (dev->of_node)
+		return of_fwnode_handle(dev->of_node);
+	else
+		return dev->fwnode;
+}
+
+int fwnode_graph_parse_endpoint(struct fwnode_handle *fwnode,
+				struct fwnode_endpoint *endpoint);
+
 #endif /* _LINUX_PROPERTY_H_ */
-- 
2.7.4


  parent reply	other threads:[~2017-02-02 16:23 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-02 16:22 [PATCH v2 00/16] ACPI graph support Sakari Ailus
2017-02-02 16:22 ` [PATCH v2 01/16] ACPI / property: Add possiblity to retrieve parent firmware node Sakari Ailus
2017-02-02 16:22 ` [PATCH v2 02/16] device property: Add fwnode_get_parent() Sakari Ailus
2017-02-02 16:22 ` [PATCH v2 03/16] ACPI / property: Add fwnode_get_next_child_node() Sakari Ailus
2017-02-02 16:22 ` [PATCH v2 04/16] device property: Add fwnode_get_named_child_node() Sakari Ailus
2017-02-02 16:22 ` [PATCH v2 05/16] ACPI / property: Add support for remote endpoints Sakari Ailus
2017-02-02 16:22 ` [PATCH v2 06/16] device " Sakari Ailus
2017-02-02 16:22 ` [PATCH v2 08/16] of: Add of_fwnode_handle() to convert device nodes to fwnode_handle Sakari Ailus
     [not found] ` <1486052546-19257-1-git-send-email-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-02-02 16:22   ` [PATCH v2 07/16] device property: Add fwnode_handle_get() Sakari Ailus
2017-02-02 16:22   ` [PATCH v2 09/16] driver core: Arrange headers alphabetically Sakari Ailus
2017-02-02 16:22   ` [PATCH v2 11/16] of: No need to include linux/property.h, linux/fwnode.h is sufficient Sakari Ailus
2017-02-20 10:37     ` [PATCH v2.1 " Sakari Ailus
2017-02-02 16:22 ` [PATCH v2 10/16] irqchip/gic: Add missing forward declaration for struct device Sakari Ailus
2017-02-02 16:22 ` Sakari Ailus [this message]
2017-02-02 16:22 ` [PATCH v2 13/16] device property: Get endpoint index from the ACPI tables Sakari Ailus
2017-02-02 16:22 ` [PATCH v2 14/16] of: Add nop implementation of of_get_next_parent() Sakari Ailus
2017-02-02 16:22 ` [PATCH v2 15/16] device property: Add fwnode_get_next_parent() Sakari Ailus
2017-02-07 18:57   ` Al Stone
     [not found]     ` <9a481aec-92e6-ac01-b825-167bf73dfb11-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-02-08 11:50       ` Rafael J. Wysocki
     [not found]         ` <6293579.fEEljmGD4Z-yvgW3jdyMHm1GS7QM15AGw@public.gmane.org>
2017-02-08 12:19           ` Rafael J. Wysocki
     [not found]             ` <7605668.5ZxNsBFnEG-yvgW3jdyMHm1GS7QM15AGw@public.gmane.org>
2017-02-08 16:49               ` Al Stone
2017-02-14  8:01                 ` Sakari Ailus
2017-02-14 17:09                   ` Al Stone
2017-02-21  8:17             ` Sakari Ailus
     [not found]               ` <20170221081749.GC16975-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2017-02-21 23:00                 ` Rafael J. Wysocki
2017-02-22 13:12                   ` Sakari Ailus
2017-02-23 17:01               ` Sakari Ailus
2017-02-02 16:22 ` [PATCH v2 16/16] ACPI / DSD: Document references, ports and endpoints Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1486052546-19257-13-git-send-email-sakari.ailus@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=ahs3@redhat.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).